test(handlers): add ExpectationsWereMet check to makeTokenHandler cleanup (PR #1460)

Per agent-reviewer REQUEST_CHANGES #7034: the new sqlmock expectations were never verified with ExpectationsWereMet, so missing SELECT/INSERT calls could pass silently. Adding the check to the makeTokenHandler cleanup covers all 4 tests that use sqlmock via the shared helper (TestGetTestToken_AdminTokenRequired_CorrectToken, TestGetTestToken_WorkspaceNotFound, TestGetTestToken_IssueTokenDBError, TestGetTestToken_ResponseContainsToken). The 3 tests that don't use sqlmock (DisabledByDefault, AdminTokenRequired_WrongToken, AdminTokenRequired_MissingBearer) get the helper but the check is a no-op for them — they early-exit on status code without hitting the DB. Closes PR #1460 review blocker.
2026-06-03 22:18:12 +00:00
parent fd94163e00
commit d1d9da57e7
1 changed files with 6 additions and 0 deletions
@@ -61,6 +61,12 @@ func makeTokenHandler(t *testing.T) (*AdminTestTokenHandler, sqlmock.Sqlmock, fu
 	prevDB := db.DB
 	db.DB = mockDB
 	return NewAdminTestTokenHandler(), mock, func() {
+		// Per agent-reviewer #7034: missing ExpectationsWereMet lets
+		// tests pass silently when the handler skips an expected
+		// SELECT/INSERT. Verify in cleanup so the failure is loud.
+		if err := mock.ExpectationsWereMet(); err != nil {
+			t.Errorf("sqlmock expectations not met: %v", err)
+		}
 		db.DB = prevDB
 		mockDB.Close()
 	}