molecule-ai/molecule-core
35
0
Fork 2
Code Issues 16 Pull Requests 2 Actions 49 Packages Projects Releases Wiki Activity

test(skills): make watcher test fakes accept current_runtime kwarg

Browse Source 
The runtime-compat change in this branch added a `current_runtime`
kwarg to load_skills(); the watcher passes it through. Test mocks
that pre-date the kwarg signature broke with TypeError, which the
watcher's reload-error try/except swallowed — the symptom was empty
callback lists, not a clear failure.

Switching the fakes to accept **kwargs keeps them forward-compat for
future load_skills additions without another test churn.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Hongming Wang 2026-04-27 02:04:26 -07:00
parent d0057912d2
commit d19d35f6b3
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
workspace/tests/test_skills_watcher.py
View File

@ -181,7 +181,7 @@ class TestReloadSkill:
tools=[], tools=[],
) )
def fake_load_skills(config_path, skill_names): def fake_load_skills(config_path, skill_names, **kwargs):
return [fake_skill] return [fake_skill]
monkeypatch.setattr(_watcher_mod, "_load_skills_impl", monkeypatch.setattr(_watcher_mod, "_load_skills_impl",
@ -218,7 +218,7 @@ class TestReloadSkill:
) )
skills_mod = ModuleType("skill_loader.loader") skills_mod = ModuleType("skill_loader.loader")
skills_mod.load_skills = lambda cp, names: [fake_skill] skills_mod.load_skills = lambda cp, names, **_: [fake_skill]
monkeypatch.setitem(sys.modules, "skill_loader.loader", skills_mod) monkeypatch.setitem(sys.modules, "skill_loader.loader", skills_mod)
await w._reload_skill("sk2", ["sk2/SKILL.md"]) await w._reload_skill("sk2", ["sk2/SKILL.md"])
@ -245,7 +245,7 @@ class TestReloadSkill:
tools=[], tools=[],
) )
skills_mod = ModuleType("skill_loader.loader") skills_mod = ModuleType("skill_loader.loader")
skills_mod.load_skills = lambda cp, names: [fake_skill] skills_mod.load_skills = lambda cp, names, **_: [fake_skill]
monkeypatch.setitem(sys.modules, "skill_loader.loader", skills_mod) monkeypatch.setitem(sys.modules, "skill_loader.loader", skills_mod)
await w._reload_skill("audited", ["audited/SKILL.md"]) await w._reload_skill("audited", ["audited/SKILL.md"])
@ -317,7 +317,7 @@ class TestWatcherLifecycle:
tools=[], tools=[],
) )
skills_mod = ModuleType("skill_loader.loader") skills_mod = ModuleType("skill_loader.loader")
skills_mod.load_skills = lambda cp, names: [fake_skill] skills_mod.load_skills = lambda cp, names, **_: [fake_skill]
monkeypatch.setitem(sys.modules, "skill_loader.loader", skills_mod) monkeypatch.setitem(sys.modules, "skill_loader.loader", skills_mod)
_watcher_mod.POLL_INTERVAL = 0.01 _watcher_mod.POLL_INTERVAL = 0.01
@ -378,7 +378,7 @@ class TestEvictStaleModules:
tools=[], tools=[],
) )
skills_mod = ModuleType("skill_loader.loader") skills_mod = ModuleType("skill_loader.loader")
skills_mod.load_skills = lambda cp, names: [fake_skill] skills_mod.load_skills = lambda cp, names, **_: [fake_skill]
monkeypatch.setitem(sys.modules, "skill_loader.loader", skills_mod) monkeypatch.setitem(sys.modules, "skill_loader.loader", skills_mod)
w = SkillsWatcher(str(tmp_path), ["sk"]) w = SkillsWatcher(str(tmp_path), ["sk"])
@ -401,7 +401,7 @@ class TestAuditEventExceptionSuppressed:
tools=[], tools=[],
) )
skills_mod = ModuleType("skill_loader.loader") skills_mod = ModuleType("skill_loader.loader")
skills_mod.load_skills = lambda cp, names: [fake_skill] skills_mod.load_skills = lambda cp, names, **_: [fake_skill]
monkeypatch.setitem(sys.modules, "skill_loader.loader", skills_mod) monkeypatch.setitem(sys.modules, "skill_loader.loader", skills_mod)
# Make tools.audit.log_event raise an exception # Make tools.audit.log_event raise an exception
@ -429,7 +429,7 @@ class TestOnReloadCallbackException:
tools=[], tools=[],
) )
skills_mod = ModuleType("skill_loader.loader") skills_mod = ModuleType("skill_loader.loader")
skills_mod.load_skills = lambda cp, names: [fake_skill] skills_mod.load_skills = lambda cp, names, **_: [fake_skill]
monkeypatch.setitem(sys.modules, "skill_loader.loader", skills_mod) monkeypatch.setitem(sys.modules, "skill_loader.loader", skills_mod)
def failing_callback(skill): def failing_callback(skill):
@ -451,7 +451,7 @@ class TestOnReloadCallbackException:
tools=[], tools=[],
) )
skills_mod = ModuleType("skill_loader.loader") skills_mod = ModuleType("skill_loader.loader")
skills_mod.load_skills = lambda cp, names: [fake_skill] skills_mod.load_skills = lambda cp, names, **_: [fake_skill]
monkeypatch.setitem(sys.modules, "skill_loader.loader", skills_mod) monkeypatch.setitem(sys.modules, "skill_loader.loader", skills_mod)
async def failing_async_callback(skill): async def failing_async_callback(skill):