Merge pull request 'test: satisfy staticcheck on PR regression tests' (#1043) from fix/staticcheck-pr-regression-tests into main

workspace-server/internal/handlers/org_helpers_pure_test.go

@@ -287,7 +287,7 @@ func TestRenderCategoryRoutingYAML_StableOrdering(t *testing.T) {
 	if ai <= 0 || zi <= 0 || mi <= 0 {
 		t.Fatalf("could not locate all keys in output: %s", out)
 	}
-	if !(ai < mi && mi < zi) {
+	if ai >= mi || mi >= zi {
 		t.Errorf("keys not sorted: alpha=%d middle=%d zebra=%d, output:\n%s", ai, mi, zi, out)
 	}
 }

workspace-server/internal/provisioner/provisioner_test.go

@@ -75,7 +75,7 @@ func TestStartSeedsConfigsBeforeContainerStart(t *testing.T) {
 	if copyTemplate < 0 || writeFiles < 0 || start < 0 {
 		t.Fatalf("expected Start to copy template, write config files, and start container")
 	}
-	if !(copyTemplate < start && writeFiles < start) {
+	if copyTemplate >= start || writeFiles >= start {
 		t.Fatalf("config seeding must happen before ContainerStart: copyTemplate=%d writeFiles=%d start=%d", copyTemplate, writeFiles, start)
 	}
 }