test(audit): bind HashValuePrefix calls to vars to satisfy staticcheck SA4000

Staticcheck SA4000 flagged the stability assertion as tautological (identical expressions on both sides of !=). Bind both calls to local vars to preserve test intent (call-stability) and silence the linter. No functional change. Follow-up to mc#1572 review (core-devops lens).
2026-05-19 20:00:26 +00:00
parent 7c751ef675
commit b5b95de19a
1 changed files with 8 additions and 3 deletions
@@ -201,8 +201,13 @@ func TestHashValuePrefix_StableAndBounded(t *testing.T) {
 	if got := HashValuePrefix("a", 999); len(got) != 64 {
 		t.Errorf("clamp-hi failed: %q", got)
 	}
-	// Stable across calls (same input → same prefix).
-	if HashValuePrefix("x", 8) != HashValuePrefix("x", 8) {
-		t.Errorf("hash not stable")
+	// Stable across calls (same input → same prefix). Bind to vars so
+	// staticcheck SA4000 does not flag the comparison as tautological;
+	// the intent is to assert call-stability, which requires invoking
+	// the function twice with the same input.
+	a := HashValuePrefix("x", 8)
+	b := HashValuePrefix("x", 8)
+	if a != b {
+		t.Errorf("hash not stable: a=%q b=%q", a, b)
 	}
 }