molecule-ai/molecule-core
41
0
Fork 2
Code Issues 103 Pull Requests 147 Actions 91 Packages Projects Releases Wiki Activity

chore: refresh stale orphan-sweeper Stop-failure comment

Browse Source 
Convergence-pass review noted the comment at orphan_sweeper.go:171
still describes the pre-cb126014 contract ("Stop returns nil even
when container is gone, but a future change could surface real
errors"). The future is now — Stop does surface real errors today.
Tightened the comment to match the live contract:
isContainerNotFound is treated as success, anything else returns
the wrapped Docker error, sweeper retries on the next cycle.

Pure comment change, no behavior diff.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Hongming Wang 2026-04-25 23:34:57 -07:00
parent cb12601414
commit b47a1b87b0
1 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
workspace-server/internal/registry/orphan_sweeper.go
View File

@ -168,12 +168,15 @@ func sweepOnce(parent context.Context, reaper OrphanReaper) {
for _, id := range orphanIDs {
log.Printf("Orphan sweeper: stopping leaked container for removed workspace %s", id)
if stopErr := reaper.Stop(ctx, id); stopErr != nil {
// Stop() itself returns nil even when container is
// gone, but a future change could surface real errors.
// Keep the volume around for the next sweep so we
// don't fall into the same Stop-failed-then-volume-
// in-use trap that motivated this sweeper.
log.Printf("Orphan sweeper: Stop failed for %s: %v — leaving volume", id, stopErr)
// Stop returns the wrapped Docker error (treating
// "container not found" as nil-success via
// isContainerNotFound), so a non-nil here means the
// container is genuinely still alive — daemon timeout,
// ctx cancellation, or a transient socket EOF.
// Skip RemoveVolume so we don't fall into the same
// Stop-failed-then-volume-in-use trap that motivated
// this sweeper. The next cycle (60s out) retries Stop.
log.Printf("Orphan sweeper: Stop failed for %s: %v — leaving volume for next cycle", id, stopErr)
continue
}
if rmErr := reaper.RemoveVolume(ctx, id); rmErr != nil {