molecule-ai/molecule-core
35
0
Fork 2
Code Issues 16 Pull Requests 2 Actions 49 Packages Projects Releases Wiki Activity

fix(canvas/e2e): broaden 401-mock to all fetches, not just /workspaces/*

Browse Source 
#2073 caught workspace-scoped 401s but missed non-workspace paths.
SkillsTab.tsx alone fetches /plugins and /plugins/sources, both
outside the /workspaces/<id>/* tree. Either of those 401s with the
tenant admin bearer in SaaS mode → canvas/src/lib/api.ts:62-74
redirects to AuthKit → page navigates away mid-test → next locator
times out.

Same failure signature observed at 16:03Z post-#2073 merge:

  e2e/staging-tabs.spec.ts:45:7 › tab: skills
  TimeoutError: locator.scrollIntoViewIfNeeded: Timeout 5000ms
  - navigated to "https://scenic-pumpkin-83.authkit.app/?..."

Broaden the route to "**" with `request.resourceType() !== "fetch"`
short-circuit (preserves HTML/JS/CSS pass-through) and a
/cp/auth/me skip (the dedicated mock above wins). Same 401 →
empty-body conversion logic; just a wider net.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Hongming Wang 2026-04-25 11:40:48 -07:00
parent 14fab6e544
commit a84b167d4d
1 changed files with 24 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

46
canvas/e2e/staging-tabs.spec.ts
View File

@ -87,33 +87,36 @@ test.describe("staging canvas tabs", () => {
}),
);
// Workspace-scoped 401 → 200 fallback.
// Universal 401 → empty-200 fallback for any fetch.
//
// Several side-panel tabs (Peers/Skills/Channels/Memory/Audit and
// anything else workspace-scoped) hit endpoints under
// `/workspaces/<id>/*` that require a workspace-scoped token, NOT
// the tenant admin bearer this test uses. Those endpoints respond
// 401 in SaaS mode. canvas/src/lib/api.ts:62-74 reacts to ANY 401
// by setting `window.location.href` to the AuthKit login URL —
// which yanks the page off the tenant origin mid-test and breaks
// every locator assertion that runs after.
// The narrow first pass (#2073, scoped to /workspaces/<id>/*) didn't
// catch all the redirect triggers — SkillsTab.tsx alone fetches
// /plugins and /plugins/sources outside the /workspaces/ tree, and
// each of those 401s with the tenant admin bearer in SaaS mode.
// canvas/src/lib/api.ts:62-74 calls `redirectToLogin` on ANY 401,
// so a single non-workspace-scoped 401 yanks the page off the
// tenant origin and breaks every locator that runs after.
//
// Broaden the route to ALL fetches: pass-through real responses,
// swap 401s for 200 + empty body. Skip `/cp/auth/me` and the
// tenant-origin HTML/JS bundle requests (resourceType !== fetch);
// those are already handled or shouldn't be intercepted.
//
// For tab-render tests we don't need real data — the gate is
// "panel mounts without crashing, no Failed-to-load toast".
// Intercept the 401 and swap it for 200 + empty body. Body shape
// is best-effort by URL: list endpoints (collection paths that
// don't end in a UUID) get `[]`; single-resource endpoints get
// `{}`. Both are valid JSON, neither matches the real schema
// exactly, but well-written panels render an empty state for
// either rather than throwing.
//
// The two route patterns don't overlap (`/workspaces/...` vs
// `/cp/auth/me`) so handler order doesn't matter — the
// `/cp/auth/me` mock above is matched on its own path.
await context.route(/\/workspaces\//, async (route, request) => {
// "panel mounts without crashing, no Failed-to-load toast". Body
// shape is best-effort by URL: list endpoints (paths not ending
// in a UUID-shaped segment) get `[]`; single-resource endpoints
// get `{}`. Both are valid JSON; well-written panels render an
// empty state for either rather than throwing.
await context.route("**", async (route, request) => {
if (request.resourceType() !== "fetch") {
return route.fallback();
}
// /cp/auth/me is mocked above with a fixed Session shape — let
// that handler win without us round-tripping the network.
if (request.url().includes("/cp/auth/me")) {
return route.fallback();
}
let resp;
try {
resp = await route.fetch();
@ -123,7 +126,6 @@ test.describe("staging canvas tabs", () => {
if (resp.status() !== 401) {
return route.fulfill({ response: resp });
}
// 401: swap for empty 200 keyed by URL shape.
const lastSeg =
new URL(request.url()).pathname.split("/").filter(Boolean).pop() || "";
const looksLikeList = !/^[0-9a-f-]{8,}$/.test(lastSeg);