Merge pull request 'fix(handlers): remove 3 duplicate test declarations blocking CI build (closes #968)' (#1002) from fix/968-remove-duplicate-test-declarations into staging
Some checks failed
Block internal-flavored paths / Block forbidden paths (push) Successful in 11s
Harness Replays / detect-changes (push) Successful in 10s
Secret scan / Scan diff for credential-shaped strings (push) Successful in 14s
CI / Detect changes (push) Successful in 30s
E2E API Smoke Test / detect-changes (push) Successful in 33s
Handlers Postgres Integration / detect-changes (push) Successful in 32s
Runtime PR-Built Compatibility / detect-changes (push) Successful in 29s
Harness Replays / Harness Replays (push) Successful in 5s
CI / Canvas (Next.js) (push) Successful in 8s
CI / Shellcheck (E2E scripts) (push) Successful in 8s
CI / Python Lint & Test (push) Successful in 9s
E2E API Smoke Test / E2E API Smoke Test (push) Successful in 2m35s
Runtime PR-Built Compatibility / PR-built wheel + import smoke (push) Successful in 3m3s
CI / Platform (Go) (push) Failing after 5m49s
Handlers Postgres Integration / Handlers Postgres Integration (push) Failing after 5m57s
CI / Canvas Deploy Reminder (push) Successful in 12s
CI / all-required (push) Successful in 8s

This commit is contained in:
devops-engineer 2026-05-14 13:09:37 +00:00
commit 9f7b87de21

View File

@ -138,23 +138,6 @@ func TestResolveInsideRoot_SiblingNotEscaped(t *testing.T) {
// ── isSafeRoleName ────────────────────────────────────────────────────────────
func TestIsSafeRoleName_Valid(t *testing.T) {
valid := []string{
"backend",
"Frontend-Engineer",
"research_lead",
"devOps123",
"a",
"A",
"team_42-leads",
}
for _, name := range valid {
if !isSafeRoleName(name) {
t.Errorf("isSafeRoleName(%q): expected true, got false", name)
}
}
}
func TestIsSafeRoleName_Empty(t *testing.T) {
if isSafeRoleName("") {
t.Error("isSafeRoleName(\"\"): expected false, got true")
@ -268,33 +251,6 @@ func TestMergeCategoryRouting_WsOverrideDropsDefault(t *testing.T) {
}
}
func TestMergeCategoryRouting_EmptyListDropsCategory(t *testing.T) {
defaultRouting := map[string][]string{
"security": {"Backend Engineer"},
"ui": {"Frontend Engineer"},
}
wsRouting := map[string][]string{
"security": {}, // empty list = opt out
}
got := mergeCategoryRouting(defaultRouting, wsRouting)
if _, exists := got["security"]; exists {
t.Error("empty ws list should delete the category from output")
}
if len(got["ui"]) != 1 {
t.Errorf("ui should still exist: got %v", got["ui"])
}
}
func TestMergeCategoryRouting_EmptyKeySkipped(t *testing.T) {
defaultRouting := map[string][]string{
"": {"Backend Engineer"},
}
got := mergeCategoryRouting(defaultRouting, nil)
if _, exists := got[""]; exists {
t.Error("empty key should be skipped")
}
}
func TestMergeCategoryRouting_EmptyRolesInDefaultSkipped(t *testing.T) {
defaultRouting := map[string][]string{
"security": {},