ci: remove canvas-deploy-reminder from all-required.needs
Some checks failed
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 12s
E2E API Smoke Test / detect-changes (pull_request) Successful in 31s
CI / Detect changes (pull_request) Successful in 38s
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 34s
Handlers Postgres Integration / detect-changes (pull_request) Successful in 29s
Lint curl status-code capture / Scan workflows for curl status-capture pollution (pull_request) Successful in 14s
lint-continue-on-error-tracking / lint-continue-on-error-tracking (pull_request) Successful in 2m0s
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m17s
Lint pre-flip continue-on-error / Verify continue-on-error flips have run-log proof (pull_request) Successful in 1m48s
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 21s
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 12s
lint-required-context-exists-in-bp / lint-required-context-exists-in-bp (pull_request) Successful in 2m5s
qa-review / approved (pull_request) Failing after 21s
Lint workflow YAML (Gitea-1.22.6-hostile shapes) / Lint workflow YAML for Gitea-1.22.6-hostile shapes (pull_request) Successful in 1m25s
security-review / approved (pull_request) Failing after 19s
sop-checklist / na-declarations (pull_request) awaiting /sop-n/a declaration for: qa-review, security-review
sop-checklist / all-items-acked (pull_request) [info tier:low] acked: 5/7 — missing: root-cause, no-backwards-compat — body-unfilled: comprehensive-testing, local-postgres-e2e, staging-sm
CI / Platform (Go) (pull_request) Successful in 9s
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 11s
CI / Canvas (Next.js) (pull_request) Successful in 11s
CI / Shellcheck (E2E scripts) (pull_request) Successful in 10s
CI / Python Lint & Test (pull_request) Successful in 10s
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 11s
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 14s
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 13s
sop-checklist-gate / gate (pull_request) Successful in 28s
gate-check-v3 / gate-check (pull_request) Failing after 51s
sop-tier-check / tier-check (pull_request) Successful in 41s
lint-mask-pr-atomicity / lint-mask-pr-atomicity (pull_request) Successful in 2m31s
CI / Canvas Deploy Reminder (pull_request) Successful in 9s
CI / all-required (pull_request) Successful in 5s

canvas-deploy-reminder needs canvas-build, which is skipped on CI-only PRs
(canvas=false). Adding it to all-required.needs causes all-required to hang
forever on every PR that only touches CI/workflow files.

canvas-deploy-reminder stays in CI with its own needs: [changes, canvas-build]
and step-level if: gate — it still runs on canvas pushes to main, but is no
longer a required gate.

Refs: mc#922, mc#923, mc#929, PR #927

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
Molecule AI · core-devops 2026-05-14 03:21:10 +00:00
parent 363905d358
commit 9831eea2ea

View File

@ -144,7 +144,7 @@ jobs:
# Fix-forward for (1) landed in PR #669. The mc#762 gap (2) is a separate
# issue — it does NOT block this flip because the test is already wrapped in
# the diagnostic step with its own continue-on-error: true (line 203).
# Flip confirmed by CI / Platform (Go) status = success on main HEAD 68560cec.
# Flip confirmed by CI / Platform (Go) status = success on main HEAD 363905d3.
continue-on-error: false
defaults:
run:
@ -562,12 +562,11 @@ jobs:
# hourly if this list diverges from status_check_contexts or from
# audit-force-merge.yml's REQUIRED_CHECKS env (RFC §4 + §6).
#
# mc#922/#923 fix: canvas-deploy-reminder added to needs: above.
# Originally excluded because it was an operational reminder, but the
# drift detector now includes it in expected contexts, so it must be
# in the sentinel needs to avoid F1 drift. Keep it runnable on PRs
# via its own `needs: [changes, canvas-build]` — the sentinel only
# aggregates the result.
# canvas-deploy-reminder is intentionally excluded from all-required.needs:
# it needs canvas-build, which is skipped on CI-only PRs (canvas=false).
# Including it in all-required.needs causes all-required to hang on
# every CI-only PR. Keep it runnable on PRs via its own
# `needs: [changes, canvas-build]` — the sentinel only aggregates the result.
#
# Phase 3 (RFC #219 §1) safety: underlying build jobs carry
# continue-on-error: true so their failures are masked to null (2026-05-12: re-enabled mc#774 interim)
@ -585,7 +584,6 @@ jobs:
- changes
- platform-build
- canvas-build
- canvas-deploy-reminder
- shellcheck
- python-lint
if: ${{ always() }}