fix(handlers/org_helpers_test): use t.Fatal instead of t.Error in error-path tests
Some checks failed
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 21s
CI / Detect changes (pull_request) Successful in 57s
E2E API Smoke Test / detect-changes (pull_request) Successful in 1m10s
Harness Replays / detect-changes (pull_request) Successful in 18s
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 1m0s
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 20s
Handlers Postgres Integration / detect-changes (pull_request) Successful in 1m1s
qa-review / approved (pull_request) Successful in 16s
gate-check-v3 / gate-check (pull_request) Successful in 29s
security-review / approved (pull_request) Successful in 16s
sop-checklist / all-items-acked (pull_request) Successful in 17s
sop-tier-check / tier-check (pull_request) Successful in 15s
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m14s
audit-force-merge / audit (pull_request) Successful in 16s
CI / Canvas (Next.js) (pull_request) Successful in 7s
CI / Shellcheck (E2E scripts) (pull_request) Successful in 5s
CI / Python Lint & Test (pull_request) Successful in 7s
Harness Replays / Harness Replays (pull_request) Successful in 6s
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 11s
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 1m42s
CI / Canvas Deploy Reminder (pull_request) Successful in 7s
CI / Platform (Go) (pull_request) Failing after 4m12s
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Failing after 4m56s
CI / all-required (pull_request) Successful in 5s

Six resolveInsideRoot tests called t.Errorf then continued to err.Error()
on a potentially-nil error — if err was unexpectedly nil, the subsequent
err.Error() call would panic with nil pointer dereference.

Fix: use t.Fatalf/t.Fatal in the nil-error branch so execution stops
before the err.Error() call. Affects:
- TestResolveInsideRoot_EmptyUserPath
- TestResolveInsideRoot_AbsolutePathRejected
- TestResolveInsideRoot_DotDotTraversal
- TestResolveInsideRoot_DotDotWithIntermediate
- TestResolveInsideRoot_NestedDotDotEscapes
- TestResolveInsideRoot_DotdotAtStart

Fixes regression reported in issue #965.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
Molecule AI · core-be 2026-05-14 05:21:17 +00:00 committed by molecule-operator
parent 2c2b06edbc
commit 95c62c6fcd

View File

@ -16,7 +16,7 @@ import (
func TestResolveInsideRoot_EmptyUserPath(t *testing.T) {
_, err := resolveInsideRoot("/safe/root", "")
if err == nil {
t.Error("empty userPath: expected error, got nil")
t.Fatal("empty userPath: expected error, got nil")
}
if err.Error() != "path is empty" {
t.Errorf("empty userPath: got %q, want %q", err.Error(), "path is empty")
@ -26,7 +26,7 @@ func TestResolveInsideRoot_EmptyUserPath(t *testing.T) {
func TestResolveInsideRoot_AbsolutePathRejected(t *testing.T) {
_, err := resolveInsideRoot("/safe/root", "/etc/passwd")
if err == nil {
t.Error("absolute userPath: expected error, got nil")
t.Fatal("absolute userPath: expected error, got nil")
}
if err.Error() != "absolute paths are not allowed" {
t.Errorf("absolute userPath: got %q, want %q", err.Error(), "absolute paths are not allowed")
@ -37,7 +37,7 @@ func TestResolveInsideRoot_DotDotTraversal(t *testing.T) {
// ../../etc/passwd from /safe/root
got, err := resolveInsideRoot("/safe/root", "../../etc/passwd")
if err == nil {
t.Errorf("dotdot traversal: expected error, got %q", got)
t.Fatalf("dotdot traversal: expected error, got %q", got)
}
if err.Error() != "path escapes root" {
t.Errorf("dotdot traversal: got %q, want %q", err.Error(), "path escapes root")
@ -48,7 +48,7 @@ func TestResolveInsideRoot_DotDotWithIntermediate(t *testing.T) {
// a/b/../../c should escape if a/b is not under root
got, err := resolveInsideRoot("/safe/root", "a/b/../../c")
if err == nil {
t.Errorf("dotdot with intermediate: expected error, got %q", got)
t.Fatalf("dotdot with intermediate: expected error, got %q", got)
}
if err.Error() != "path escapes root" {
t.Errorf("dotdot with intermediate: got %q, want %q", err.Error(), "path escapes root")
@ -97,7 +97,7 @@ func TestResolveInsideRoot_NestedDotDotEscapes(t *testing.T) {
// a/../../b from /tmp/dirsomething → /tmp/b (escapes temp dir)
got, err := resolveInsideRoot(root, "a/../../b")
if err == nil {
t.Errorf("nested dotdot: expected error, got %q", got)
t.Fatalf("nested dotdot: expected error, got %q", got)
}
if err.Error() != "path escapes root" {
t.Errorf("nested dotdot: got %q, want %q", err.Error(), "path escapes root")
@ -108,7 +108,7 @@ func TestResolveInsideRoot_DotdotAtStart(t *testing.T) {
root := t.TempDir()
got, err := resolveInsideRoot(root, "../sibling")
if err == nil {
t.Errorf("../sibling: expected error, got %q", got)
t.Fatalf("../sibling: expected error, got %q", got)
}
if err.Error() != "path escapes root" {
t.Errorf("../sibling: got %q, want %q", err.Error(), "path escapes root")