From 8f416bba26cfbd040ad01320d56a3646a096666a Mon Sep 17 00:00:00 2001 From: Molecule AI Infra-SRE Date: Sat, 16 May 2026 18:06:30 +0000 Subject: [PATCH] fix(review-refire-comments): eliminate duplicate steps block causing YAML error MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The consolidation commit (PR #1333) attempted to convert this workflow into a no-op stub by adding a deprecation step, but left the original dispatch steps in place — producing two `runs-on:` and two `steps:` blocks under the `dispatch` job. YAML allowed this (merging the duplicate `steps:` keys) so it parsed silently, but the original refire logic still ran, defeating the entire purpose of the deprecation stub. Fix: replace the file with a clean 39-line no-op stub that emits a warning and exits immediately. All refire logic lives in sop-checklist.yml review-refire job per issue #1280. Co-Authored-By: Claude Opus 4.7 --- .gitea/workflows/review-refire-comments.yml | 87 --------------------- 1 file changed, 87 deletions(-) diff --git a/.gitea/workflows/review-refire-comments.yml b/.gitea/workflows/review-refire-comments.yml index 1fa226d0..f5e8d6d8 100644 --- a/.gitea/workflows/review-refire-comments.yml +++ b/.gitea/workflows/review-refire-comments.yml @@ -37,90 +37,3 @@ jobs: run: | echo "::warning::review-refire-comments.yml is deprecated. Refire logic is now in sop-checklist.yml review-refire job. This workflow is a no-op stub pending deletion (issue #1280)." exit 0 - runs-on: ubuntu-latest - steps: - - name: Classify comment - id: classify - env: - COMMENT_BODY: ${{ github.event.comment.body }} - IS_PR: ${{ github.event.issue.pull_request != null }} - run: | - set -euo pipefail - { - echo "run_qa=false" - echo "run_security=false" - echo "run_tier=false" - } >> "$GITHUB_OUTPUT" - if [ "$IS_PR" != "true" ]; then - echo "::notice::not a PR comment; no-op" - exit 0 - fi - first_line=$(printf '%s\n' "$COMMENT_BODY" | sed -n '1p') - case "$first_line" in - /qa-recheck*) - echo "run_qa=true" >> "$GITHUB_OUTPUT" - ;; - /security-recheck*) - echo "run_security=true" >> "$GITHUB_OUTPUT" - ;; - /refire-tier-check*) - echo "run_tier=true" >> "$GITHUB_OUTPUT" - ;; - *) - echo "::notice::no supported review refire slash command; no-op" - ;; - esac - - - name: Check out BASE ref for trusted scripts - if: | - steps.classify.outputs.run_qa == 'true' || - steps.classify.outputs.run_security == 'true' || - steps.classify.outputs.run_tier == 'true' - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 - with: - ref: ${{ github.event.repository.default_branch }} - - - name: Refire qa-review status - if: steps.classify.outputs.run_qa == 'true' - env: - GITEA_TOKEN: ${{ secrets.RFC_324_TEAM_READ_TOKEN || secrets.GITHUB_TOKEN }} - GITEA_HOST: git.moleculesai.app - REPO: ${{ github.repository }} - PR_NUMBER: ${{ github.event.issue.number }} - DEFAULT_BRANCH: ${{ github.event.repository.default_branch }} - TEAM: qa - TEAM_ID: '20' - REVIEW_CHECK_DEBUG: '0' - REVIEW_CHECK_STRICT: '0' - COMMENT_AUTHOR: ${{ github.event.comment.user.login }} - run: | - set -euo pipefail - .gitea/scripts/review-refire-status.sh - - - name: Refire security-review status - if: steps.classify.outputs.run_security == 'true' - env: - GITEA_TOKEN: ${{ secrets.RFC_324_TEAM_READ_TOKEN || secrets.GITHUB_TOKEN }} - GITEA_HOST: git.moleculesai.app - REPO: ${{ github.repository }} - PR_NUMBER: ${{ github.event.issue.number }} - DEFAULT_BRANCH: ${{ github.event.repository.default_branch }} - TEAM: security - TEAM_ID: '21' - REVIEW_CHECK_DEBUG: '0' - REVIEW_CHECK_STRICT: '0' - COMMENT_AUTHOR: ${{ github.event.comment.user.login }} - run: | - set -euo pipefail - .gitea/scripts/review-refire-status.sh - - - name: Refire sop-tier-check status - if: steps.classify.outputs.run_tier == 'true' - env: - GITEA_TOKEN: ${{ secrets.SOP_TIER_CHECK_TOKEN || secrets.GITHUB_TOKEN }} - GITEA_HOST: git.moleculesai.app - REPO: ${{ github.repository }} - PR_NUMBER: ${{ github.event.issue.number }} - COMMENT_AUTHOR: ${{ github.event.comment.user.login }} - SOP_DEBUG: '0' - run: bash .gitea/scripts/sop-tier-refire.sh