From 5478beef902ced478e73d6f8d5fb81463b5e0580 Mon Sep 17 00:00:00 2001 From: rabbitblood Date: Sun, 26 Apr 2026 14:36:02 -0700 Subject: [PATCH] fix(canary): bump job timeout to 25m so bash fail + diagnostic can fire (#2090) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit PR #2107 bumped the bash-side TLS-readiness deadline in tests/e2e/test_staging_full_saas.sh from 600s to 900s (15 min) AND added a diagnostic burst on the fail path so the next failure would identify the broken layer (DNS / TLS / HTTP). What I missed: the canary workflow's own timeout-minutes was also 15. So GitHub Actions killed the job at the 15:00 wall-clock mark BEFORE the bash `fail` + diagnostic could fire — every cancellation silent, no failure comment on #2090, no diagnostic data attached. Visible in the 21:03 UTC canary run: cancelled at 14:03 step time (15:18 wall) without ever reaching the diagnostic block. Bump to 25 min — gives ~10 min headroom over the 15-min bash deadline for setup (org create + tenant provision + admin token fetch) plus the diagnostic dump plus teardown. Still tighter than the sibling staging E2E jobs (20/40/45 min) so a genuine wedge surfaces here first. Co-Authored-By: Claude Opus 4.7 (1M context) --- .github/workflows/canary-staging.yml | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/.github/workflows/canary-staging.yml b/.github/workflows/canary-staging.yml index 0c4bae19..f013ee21 100644 --- a/.github/workflows/canary-staging.yml +++ b/.github/workflows/canary-staging.yml @@ -38,7 +38,14 @@ jobs: canary: name: Canary smoke runs-on: ubuntu-latest - timeout-minutes: 15 + # 25 min headroom over the 15-min TLS-readiness deadline in + # tests/e2e/test_staging_full_saas.sh (#2107). Without the buffer + # the job is killed at the wall-clock 15:00 mark BEFORE the bash + # `fail` + diagnostic burst can fire, leaving every cancellation + # silent. Sibling staging E2E jobs run at 20-45 min — keeping + # canary tighter than them so a true wedge still surfaces here + # first. + timeout-minutes: 25 env: MOLECULE_CP_URL: https://staging-api.moleculesai.app