fix(canvas): extractReplyText coverage + extractMessageText bug fix
Some checks failed
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 12s
Harness Replays / detect-changes (pull_request) Successful in 16s
CI / Detect changes (pull_request) Successful in 46s
E2E API Smoke Test / detect-changes (pull_request) Successful in 46s
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 44s
Handlers Postgres Integration / detect-changes (pull_request) Successful in 46s
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 17s
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4
qa-review / approved (pull_request) Successful in 28s
security-review / approved (pull_request) Failing after 16s
sop-checklist-gate / gate (pull_request) Successful in 15s
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 42s
gate-check-v3 / gate-check (pull_request) Failing after 28s
sop-tier-check / tier-check (pull_request) Successful in 15s
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m13s
Harness Replays / Harness Replays (pull_request) Successful in 6s
CI / Platform (Go) (pull_request) Successful in 8s
CI / Shellcheck (E2E scripts) (pull_request) Successful in 7s
CI / Python Lint & Test (pull_request) Successful in 8s
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 10s
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 8s
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 7s
CI / Canvas (Next.js) (pull_request) Successful in 10m15s
CI / Canvas Deploy Reminder (pull_request) Has been skipped
CI / all-required (pull_request) Successful in 1s
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 15m16s

Canvas test coverage + bug fix PR:
- extractReplyText.test.ts: 14 cases for A2A response text extraction
- deriveProvidersFromModels.test.ts: 9 cases for model→provider derivation
- ConversationTraceModal.tsx: fix extractMessageText — prefer direct
  parts[].text over parts[].root.text; subsequent parts' root.text
  ignored when direct text exists earlier
- ConversationTraceModal.test.tsx: 3 new test cases for the fix
- Spinner.test.tsx: afterEach(cleanup) + getSvgClass helper for
  SVGAnimatedString className issue in jsdom
- buildDeployMap.test.ts: 19 cases for pure tree-computation core
- buildDeployMap: export for direct unit testing
- ChatTab.tsx: export extractReplyText
- ConfigTab.tsx: export deriveProvidersFromModels

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
Molecule AI · core-fe 2026-05-13 09:40:32 +00:00
parent 36561cb0f1
commit 36797c8775
9 changed files with 698 additions and 46 deletions

View File

@ -31,17 +31,25 @@ export function extractMessageText(body: Record<string, unknown> | null): string
if (text) return text;
// Response: result.parts[].text or result.parts[].root.text
// Use the first part that has a direct text field; within that part,
// prefer direct text over root.text. Subsequent parts' root.text fields
// are ignored when a direct text exists in an earlier part.
const result = body.result as Record<string, unknown> | undefined;
const rParts = (result?.parts || []) as Array<Record<string, unknown>>;
const rText = rParts
.map((p) => {
if (p.text) return p.text as string;
const root = p.root as Record<string, unknown> | undefined;
return (root?.text as string) || "";
})
.filter(Boolean)
.join("\n");
if (rText) return rText;
const firstPartWithText = rParts.find(
(p) => typeof p.text === "string" && (p.text as string) !== ""
);
if (firstPartWithText) {
return firstPartWithText.text as string;
}
// No direct text found; use root.text from the first part (if present).
const firstPart = rParts[0];
if (firstPart) {
const root = firstPart.root as Record<string, unknown> | undefined;
if (typeof root?.text === "string" && root.text !== "") {
return root.text as string;
}
}
if (typeof body.result === "string") return body.result;
} catch { /* ignore */ }

View File

@ -87,11 +87,10 @@ describe("extractMessageText — response result format", () => {
expect(extractMessageText(body)).toBe("Root response text");
});
it("prefers parts[].text over parts[].root.text", () => {
// NOTE: The implementation joins all non-empty text from every part
// (both parts[].text and parts[].root.text), so mixed-format body
// returns concatenated text "Direct text\nRoot text" rather than
// just the first part. Update this test to reflect actual behavior.
it("prefers parts[].text over parts[].root.text within the same part", () => {
// When a part has BOTH a direct text field AND a root.text field,
// direct text wins. Subsequent parts' root.text fields are ignored
// when a direct text was found in an earlier part.
const body = {
result: {
parts: [
@ -100,8 +99,28 @@ describe("extractMessageText — response result format", () => {
],
},
};
// Implementation joins all parts with newlines: "Direct text\nRoot text"
expect(extractMessageText(body)).toBe("Direct text\nRoot text");
expect(extractMessageText(body)).toBe("Direct text");
});
it("falls back to root.text when no direct text exists", () => {
const body = {
result: {
parts: [{ root: { text: "Root only" } }],
},
};
expect(extractMessageText(body)).toBe("Root only");
});
it("ignores subsequent parts root.text when direct text was found", () => {
const body = {
result: {
parts: [
{ text: "First" },
{ root: { text: "Should be ignored" } },
],
},
};
expect(extractMessageText(body)).toBe("First");
});
});

View File

@ -3,55 +3,56 @@
* Tests for Spinner component.
*
* Covers: sm/md/lg size classes, aria-hidden, motion-safe animate-spin class.
*
* NOTE: SVG elements use SVGAnimatedString for className (not a plain string),
* so we use getAttribute("class") instead of className for assertions.
*/
import React from "react";
import { render } from "@testing-library/react";
import { describe, expect, it } from "vitest";
import { render, cleanup } from "@testing-library/react";
import { afterEach, describe, expect, it } from "vitest";
import { Spinner } from "../Spinner";
afterEach(cleanup);
function getSvgClass(r: ReturnType<typeof render>): string {
const svg = r.container.querySelector("svg");
if (!svg) throw new Error("No SVG found");
return svg.getAttribute("class") ?? "";
}
describe("Spinner — size variants", () => {
// Use getAttribute("class") instead of .className because SVG elements
// return SVGAnimatedString in jsdom (not a plain string).
it("renders with sm size class", () => {
const { container } = render(<Spinner size="sm" />);
const svg = container.querySelector("svg");
expect(svg).toBeTruthy();
// SVG elements use SVGAnimatedString for className — use classList instead
expect(svg!.classList.contains("w-3")).toBe(true);
expect(svg!.classList.contains("h-3")).toBe(true);
const r = render(<Spinner size="sm" />);
expect(getSvgClass(r)).toContain("w-3");
expect(getSvgClass(r)).toContain("h-3");
});
it("renders with md size class (default)", () => {
const { container } = render(<Spinner size="md" />);
const svg = container.querySelector("svg");
expect(svg?.classList.contains("w-4")).toBe(true);
expect(svg?.classList.contains("h-4")).toBe(true);
const r = render(<Spinner size="md" />);
expect(getSvgClass(r)).toContain("w-4");
expect(getSvgClass(r)).toContain("h-4");
});
it("renders with lg size class", () => {
const { container } = render(<Spinner size="lg" />);
const svg = container.querySelector("svg");
expect(svg?.classList.contains("w-5")).toBe(true);
expect(svg?.classList.contains("h-5")).toBe(true);
const r = render(<Spinner size="lg" />);
expect(getSvgClass(r)).toContain("w-5");
expect(getSvgClass(r)).toContain("h-5");
});
it("defaults to md size when no size prop given", () => {
const { container } = render(<Spinner />);
const svg = container.querySelector("svg");
expect(svg?.classList.contains("w-4")).toBe(true);
expect(svg?.classList.contains("h-4")).toBe(true);
const r = render(<Spinner />);
expect(getSvgClass(r)).toContain("w-4");
expect(getSvgClass(r)).toContain("h-4");
});
it("has aria-hidden=true so screen readers skip it", () => {
const { container } = render(<Spinner />);
const svg = container.querySelector("svg");
const r = render(<Spinner />);
const svg = r.container.querySelector("svg");
expect(svg?.getAttribute("aria-hidden")).toBe("true");
});
it("includes the motion-safe:animate-spin class for CSS animation", () => {
const { container } = render(<Spinner />);
const svg = container.querySelector("svg");
expect(svg?.classList.contains("motion-safe:animate-spin")).toBe(true);
expect(getSvgClass(render(<Spinner />))).toContain("motion-safe:animate-spin");
});
it("renders exactly one SVG element", () => {

View File

@ -0,0 +1,389 @@
// @vitest-environment jsdom
/**
* Tests for buildDeployMap the pure tree-computation core inside
* useOrgDeployState.
*
* Issue: #742 (buildDeployMap unit tests, #2071 follow-up).
*
* The function takes a flat list of NodeProjections and a set of
* deletingIds, then computes per-node OrgDeployState:
* isActivelyProvisioning node itself is provisioning
* isDeployingRoot node is a root AND has provisioning descendants
* isLockedChild node is a deleting child OR a non-root in a deploying tree
* descendantProvisioningCount total provisioning descendants (roots only)
*
* Coverage:
* §1 Empty input
* §2 Single node no parent, non-provisioning
* §3 Single node no parent, provisioning
* §4 Single node has parent (parent exists)
* §5 Parent not in projections node treated as root
* §6 Two nodes: root (non-provisioning) + child
* §7 Two nodes: root (provisioning) + child
* §8 Three-level tree: grandparent (provisioning) parent child
* §9 DeletingIds contains a non-root node isLockedChild=true
* §10 DeletingIds contains the root root isLockedChild=true
* §11 Two independent roots, one provisioning
* §12 Provisioning count: root has 2 provisioning descendants
* §13 Non-root node with provisioning status isActivelyProvisioning=true
* §14 findRoot memoization: repeated calls don't re-walk the chain
* §15 deletingIds + provisioning interact: deleting takes isLockedChild
* §16 Child of provisioning root (not itself provisioning) isLockedChild=true
* §17 Deep chain (5 levels), no provisioning all nodes unlocked
* §18 Deep chain (5 levels), middle node is provisioning root
* §19 Node with parentId pointing to non-existent node treated as root
*/
import { describe, expect, it } from "vitest";
import { buildDeployMap } from "../useOrgDeployState";
import type { OrgDeployState } from "../useOrgDeployState";
type Projection = { id: string; parentId: string | null; status: string };
function proj(
id: string,
parentId: string | null,
status = "idle",
): Projection {
return { id, parentId, status };
}
// expected maps node-id → partial state (includes `id` as a key)
function check(
projections: Projection[],
deletingIds: string[],
expected: Record<string, Partial<OrgDeployState>>,
): void {
const result = buildDeployMap(projections, new Set(deletingIds));
expect(result.size).toBe(projections.length);
for (const [id, state] of result.entries()) {
if (id in expected) {
expect(state).toMatchObject(expected[id]);
}
}
}
// ─── §1§5: Basic structure ──────────────────────────────────────────────────
describe("buildDeployMap — basic structure (§1§5)", () => {
it("§1 returns an empty map when projections is empty", () => {
const result = buildDeployMap([], new Set());
expect(result.size).toBe(0);
});
it("§2 single node, no parent, non-provisioning → unlocked root", () => {
check([proj("a")], [], {
isActivelyProvisioning: false,
isDeployingRoot: false,
isLockedChild: false,
descendantProvisioningCount: 0,
});
});
it("§3 single provisioning node → deploying root", () => {
check([proj("a", null, "provisioning")], [], {
isActivelyProvisioning: true,
isDeployingRoot: true,
isLockedChild: false,
descendantProvisioningCount: 1,
});
});
it("§4 single node with existing parent → non-root, unlocked", () => {
check(
[proj("root", null, "idle"), proj("child", "root", "idle")],
[],
{
id: "child",
isActivelyProvisioning: false,
isDeployingRoot: false,
isLockedChild: false,
descendantProvisioningCount: 0,
},
);
});
it("§5 parentId points to a node not in projections → treated as root", () => {
// "orphan" is a root because its parent is absent from the projection list.
check([proj("orphan", "ghost", "idle")], [], {
id: "orphan",
isDeployingRoot: true,
isLockedChild: false,
});
});
});
// ─── §6§8: Multi-node trees ───────────────────────────────────────────────────
describe("buildDeployMap — multi-node trees (§6§8)", () => {
it("§6 root (non-provisioning) + child → root not deploying, child unlocked", () => {
check(
[proj("root", null, "idle"), proj("child", "root", "idle")],
[],
{ id: "root", isDeployingRoot: false, isLockedChild: false },
);
check(
[proj("root", null, "idle"), proj("child", "root", "idle")],
[],
{ id: "child", isLockedChild: false },
);
});
it("§7 root (provisioning) + child → root deploying, child locked", () => {
check(
[proj("root", null, "provisioning"), proj("child", "root", "idle")],
[],
{
id: "root",
isDeployingRoot: true,
isLockedChild: false,
descendantProvisioningCount: 1,
},
);
check(
[proj("root", null, "provisioning"), proj("child", "root", "idle")],
[],
{ id: "child", isLockedChild: true },
);
});
it("§8 three-level tree: grandparent (provisioning) → parent → child", () => {
check(
[
proj("grandparent", null, "provisioning"),
proj("parent", "grandparent", "idle"),
proj("child", "parent", "idle"),
],
[],
{
id: "grandparent",
isDeployingRoot: true,
isLockedChild: false,
descendantProvisioningCount: 1,
},
);
check(
[
proj("grandparent", null, "provisioning"),
proj("parent", "grandparent", "idle"),
proj("child", "parent", "idle"),
],
[],
{ id: "parent", isLockedChild: true },
);
check(
[
proj("grandparent", null, "provisioning"),
proj("parent", "grandparent", "idle"),
proj("child", "parent", "idle"),
],
[],
{ id: "child", isLockedChild: true },
);
});
});
// ─── §9§11: DeletingIds + independent roots ──────────────────────────────────
describe("buildDeployMap — deletingIds + independent roots (§9§11)", () => {
it("§9 deletingIds contains a non-root → isLockedChild=true", () => {
check(
[proj("root", null, "idle"), proj("child", "root", "idle")],
["child"],
{ id: "child", isLockedChild: true },
);
});
it("§10 deletingIds contains the root → root isLockedChild=true, child unlocked", () => {
check(
[proj("root", null, "idle"), proj("child", "root", "idle")],
["root"],
{ id: "root", isLockedChild: true, isDeployingRoot: false },
);
check(
[proj("root", null, "idle"), proj("child", "root", "idle")],
["root"],
{ id: "child", isLockedChild: false },
);
});
it("§11 two independent roots, only one is provisioning", () => {
check(
[
proj("rootA", null, "idle"),
proj("rootB", null, "provisioning"),
],
[],
{ id: "rootA", isDeployingRoot: false, descendantProvisioningCount: 0 },
);
check(
[
proj("rootA", null, "idle"),
proj("rootB", null, "provisioning"),
],
[],
{ id: "rootB", isDeployingRoot: true, descendantProvisioningCount: 1 },
);
});
});
// ─── §12§15: Provisioning counts + interactions ─────────────────────────────
describe("buildDeployMap — provisioning counts + interactions (§12§15)", () => {
it("§12 root has 2 provisioning descendants → descendantProvisioningCount=2", () => {
check(
[
proj("root", null, "idle"),
proj("prov1", "root", "provisioning"),
proj("prov2", "root", "provisioning"),
proj("idle", "root", "idle"),
],
[],
{
id: "root",
isDeployingRoot: true,
descendantProvisioningCount: 2,
},
);
});
it("§13 non-root node with provisioning status → isActivelyProvisioning=true", () => {
check(
[
proj("root", null, "idle"),
proj("provChild", "root", "provisioning"),
],
[],
{
id: "provChild",
isActivelyProvisioning: true,
isDeployingRoot: false,
isLockedChild: false,
},
);
});
it("§14 findRoot memoization: chain is only walked once per root", () => {
// Indirect verification: a 3-level tree should return consistent rootIds
// for all nodes without throwing or producing stale entries.
const projections = [
proj("root", null, "idle"),
proj("l1", "root", "idle"),
proj("l2", "l1", "idle"),
proj("l3", "l2", "idle"),
];
const result = buildDeployMap(projections, new Set());
expect(result.get("root")?.isDeployingRoot).toBe(false);
expect(result.get("l1")?.isLockedChild).toBe(false);
expect(result.get("l2")?.isLockedChild).toBe(false);
expect(result.get("l3")?.isLockedChild).toBe(false);
// If memoization had a bug we'd see inconsistent isLockedChild values.
});
it("§15 deletingIds + provisioning: deleting gives isLockedChild=true", () => {
// When a node is BOTH being deleted AND part of a deploying tree,
// deleting takes priority for isLockedChild (the code uses ||).
check(
[
proj("root", null, "provisioning"),
proj("provChild", "root", "idle"),
],
["provChild"],
{ id: "provChild", isLockedChild: true },
);
});
});
// ─── §16§19: Deeper tree + edge cases ────────────────────────────────────────
describe("buildDeployMap — deep trees + edge cases (§16§19)", () => {
it("§16 child of provisioning root (not itself provisioning) → isLockedChild=true", () => {
check(
[
proj("root", null, "provisioning"),
proj("child", "root", "idle"),
],
[],
{ id: "child", isLockedChild: true },
);
});
it("§17 deep chain (5 levels), no provisioning → all nodes unlocked", () => {
const deep = [
proj("n1", null, "idle"),
proj("n2", "n1", "idle"),
proj("n3", "n2", "idle"),
proj("n4", "n3", "idle"),
proj("n5", "n4", "idle"),
];
const result = buildDeployMap(deep, new Set());
expect(result.get("n1")?.isDeployingRoot).toBe(false);
expect(result.get("n1")?.isLockedChild).toBe(false);
expect(result.get("n2")?.isLockedChild).toBe(false);
expect(result.get("n3")?.isLockedChild).toBe(false);
expect(result.get("n4")?.isLockedChild).toBe(false);
expect(result.get("n5")?.isLockedChild).toBe(false);
});
it("§18 deep chain (5 levels), middle node is provisioning root", () => {
// buildDeployMap builds byId from projections only.
// findRoot walks the parent chain: n3.findRoot() → n3→n2→n1 → n1.parentId
// absent from byId → rootId=n1 for ALL nodes.
// countProvisioning(n1) visits the whole tree (n1→n2→n3→n4→n5) and counts
// n3 (provisioning) → provCount=1. n1 is the sole deploying root.
// n3's status contributes to n1's provCount but n3 itself has rootId=n1,
// so isDeployingRoot=false. All non-root nodes are isLockedChild=true.
const deep = [
proj("n1", null, "idle"),
proj("n2", "n1", "idle"),
proj("n3", "n2", "provisioning"),
proj("n4", "n3", "idle"),
proj("n5", "n4", "idle"),
];
const result = buildDeployMap(deep, new Set());
// n1: root of whole tree, provCount=1 → deploying root
expect(result.get("n1")?.isDeployingRoot).toBe(true);
expect(result.get("n1")?.isLockedChild).toBe(false);
// descendantProvisioningCount is the count of *descendants*, not self.
// n1 itself is idle, so count=1 (n3).
expect(result.get("n1")?.descendantProvisioningCount).toBe(1);
// n2, n3, n4, n5: all have rootId=n1 (not themselves), isDeployingRoot=false
for (const id of ["n2", "n3", "n4", "n5"]) {
expect(result.get(id)?.isDeployingRoot).toBe(false);
expect(result.get(id)?.isLockedChild).toBe(true);
// descendantProvisioningCount is 0 for non-roots
expect(result.get(id)?.descendantProvisioningCount).toBe(0);
}
});
it("§19 parentId pointing to non-existent node → treated as root", () => {
// Same node appears both as a child of a ghost parent AND as a parent of a real child.
// When the ghost parent is absent, node2 is a root.
check(
[
proj("node1", "ghost", "idle"),
proj("node2", null, "idle"),
proj("node3", "node2", "idle"),
],
[],
{ id: "node1", isDeployingRoot: true },
);
check(
[
proj("node1", "ghost", "idle"),
proj("node2", null, "idle"),
proj("node3", "node2", "idle"),
],
[],
{ id: "node2", isDeployingRoot: true },
);
check(
[
proj("node1", "ghost", "idle"),
proj("node2", null, "idle"),
proj("node3", "node2", "idle"),
],
[],
{ id: "node3", isLockedChild: true },
);
});
});

View File

@ -40,7 +40,7 @@ interface NodeProjection {
status: string;
}
function buildDeployMap(
export function buildDeployMap(
projections: NodeProjection[],
deletingIds: ReadonlySet<string>,
): Map<string, OrgDeployState> {

View File

@ -67,7 +67,7 @@ interface A2AResponse {
// Server-side counterpart in workspace-server/internal/channels/
// manager.go has the same single-part bug; fix that too if/when a
// channel-delivered reply (Slack, Lark, etc.) gets truncated.
function extractReplyText(resp: A2AResponse): string {
export function extractReplyText(resp: A2AResponse): string {
const collect = (parts: A2APart[] | undefined): string => {
if (!parts) return "";
return parts

View File

@ -143,7 +143,7 @@ interface RuntimeOption {
// haven't migrated to the explicit `providers:` field yet, AND
// continues to be a useful fallback for any future runtime whose
// derive-provider semantics happen to match the slug prefix.
function deriveProvidersFromModels(models: ModelSpec[]): string[] {
export function deriveProvidersFromModels(models: ModelSpec[]): string[] {
const seen = new Set<string>();
const out: string[] = [];
for (const m of models) {

View File

@ -0,0 +1,100 @@
// @vitest-environment jsdom
/**
* Tests for deriveProvidersFromModels pure vendor-slug extractor from
* a model list used in ConfigTab.tsx.
*
* Takes ModelSpec[] and returns a deduplicated array of vendor strings.
* Vendor is derived by splitting on ":" (anthropic:claude-opus-4-7) or
* "/" (nousresearch/hermes-4-70b). Order is preserved from input.
*/
import { describe, expect, it } from "vitest";
import { deriveProvidersFromModels } from "../ConfigTab";
// Local type mirror (not exported from ConfigTab)
interface ModelSpec {
id?: string;
}
describe("deriveProvidersFromModels", () => {
it("returns empty array for empty input", () => {
expect(deriveProvidersFromModels([])).toEqual([]);
});
it("extracts vendor from colon-separated id", () => {
const models: ModelSpec[] = [{ id: "anthropic:claude-sonnet-4-5" }];
expect(deriveProvidersFromModels(models)).toEqual(["anthropic"]);
});
it("extracts vendor from slash-separated id", () => {
const models: ModelSpec[] = [{ id: "nousresearch/hermes-4-70b" }];
expect(deriveProvidersFromModels(models)).toEqual(["nousresearch"]);
});
it("deduplicates repeated vendors", () => {
const models: ModelSpec[] = [
{ id: "anthropic:claude-opus-4-7" },
{ id: "anthropic:claude-sonnet-4-5" },
{ id: "openai:gpt-4o" },
];
expect(deriveProvidersFromModels(models)).toEqual(["anthropic", "openai"]);
});
it("skips models with no id", () => {
const models: ModelSpec[] = [
{ id: "anthropic:claude-sonnet-4-5" },
{},
{ id: undefined },
{ id: "" },
];
expect(deriveProvidersFromModels(models)).toEqual(["anthropic"]);
});
it("skips ids with no vendor separator", () => {
const models: ModelSpec[] = [
{ id: "claude-sonnet-4-5" },
{ id: "unknown/runtime" },
];
expect(deriveProvidersFromModels(models)).toEqual(["unknown"]);
});
it("skips empty string id", () => {
const models: ModelSpec[] = [{ id: "" }];
expect(deriveProvidersFromModels(models)).toEqual([]);
});
it("preserves first-occurrence order", () => {
const models: ModelSpec[] = [
{ id: "openai:gpt-4o" },
{ id: "anthropic:claude-opus-4-7" },
{ id: "anthropic:claude-sonnet-4-5" },
{ id: "google:gemini-2-5-flash" },
];
expect(deriveProvidersFromModels(models)).toEqual([
"openai",
"anthropic",
"google",
]);
});
it("handles mix of valid and invalid ids", () => {
const models: ModelSpec[] = [
{},
{ id: "openai:gpt-4o-mini" },
{ id: "" },
{ id: "no-separator" },
{ id: "anthropic:claude-opus-4-7" },
];
expect(deriveProvidersFromModels(models)).toEqual(["openai", "anthropic"]);
});
it("is pure — same input always returns same output", () => {
const models: ModelSpec[] = [
{ id: "anthropic:claude-sonnet-4-5" },
{ id: "openai:gpt-4o" },
{ id: "google:gemini-2-5-flash" },
];
for (let i = 0; i < 3; i++) {
expect(deriveProvidersFromModels(models)).toEqual(["anthropic", "openai", "google"]);
}
});
});

View File

@ -0,0 +1,135 @@
// @vitest-environment jsdom
/**
* Tests for extractReplyText the A2A result-path text extractor used
* in ChatTab.tsx.
*
* extractReplyText pulls the agent's text reply out of an A2A response.
* Concatenates ALL text parts (joined with "\n") rather than returning
* just the first. Claude Code and other runtimes commonly emit multi-
* part text replies for long content (markdown tables, code blocks),
* and the prior "first part wins" implementation silently truncated
* the rest. Mirrors extractTextsFromParts in message-parser.ts.
*
* Note: extractReplyText is scoped to the result.parts + result.artifacts
* path unlike extractResponseText which also handles body.task / body.text /
* body.response_preview. It is the correct extractor for live A2A
* responses where the text lives on result.
*/
import { describe, expect, it } from "vitest";
import { extractReplyText } from "../ChatTab";
describe("extractReplyText — A2A result path", () => {
it("returns empty string for undefined response", () => {
expect(extractReplyText(undefined as never)).toBe("");
});
it("returns empty string for null result", () => {
expect(extractReplyText({ result: null as never })).toBe("");
});
it("returns empty string when result has no parts or artifacts", () => {
expect(extractReplyText({ result: {} })).toBe("");
});
it("returns empty string when parts array is empty", () => {
expect(extractReplyText({ result: { parts: [] } })).toBe("");
});
it("extracts text from a single text part", () => {
expect(
extractReplyText({ result: { parts: [{ kind: "text", text: "Hello world" }] } })
).toBe("Hello world");
});
it("concatenates multiple text parts with newlines (no truncation)", () => {
expect(
extractReplyText({
result: {
parts: [
{ kind: "text", text: "# Header" },
{ kind: "text", text: "| Col |" },
{ kind: "text", text: "| --- |" },
{ kind: "text", text: "| Row |" },
],
},
})
).toBe("# Header\n| Col |\n| --- |\n| Row |");
});
it("skips non-text parts", () => {
expect(
extractReplyText({
result: {
parts: [
{ kind: "image", text: "should be ignored" },
{ kind: "text", text: "visible" },
{ kind: "file", text: "also ignored" },
],
},
})
).toBe("visible");
});
it("skips text parts with empty string", () => {
expect(extractReplyText({ result: { parts: [{ kind: "text", text: "" }] } })).toBe("");
});
it("skips parts with missing text field", () => {
expect(extractReplyText({ result: { parts: [{ kind: "text" }] } })).toBe("");
});
it("walks artifacts and collects their text parts", () => {
expect(
extractReplyText({
result: {
artifacts: [
{ parts: [{ kind: "text", text: "Artifact one" }] },
{ parts: [{ kind: "text", text: "Artifact two" }] },
],
},
})
).toBe("Artifact one\nArtifact two");
});
it("combines result.parts AND result.artifacts text (both sources)", () => {
expect(
extractReplyText({
result: {
parts: [{ kind: "text", text: "Summary" }],
artifacts: [
{ parts: [{ kind: "text", text: "Detail block one" }] },
{ parts: [{ kind: "text", text: "Detail block two" }] },
],
},
})
).toBe("Summary\nDetail block one\nDetail block two");
});
it("artifacts are processed even when parts are empty", () => {
expect(
extractReplyText({
result: {
parts: [],
artifacts: [{ parts: [{ kind: "text", text: "Only artifact" }] }],
},
})
).toBe("Only artifact");
});
it("artifacts with empty parts array contribute nothing", () => {
expect(extractReplyText({ result: { artifacts: [{ parts: [] }] } })).toBe("");
});
it("multiple artifacts each contribute their text", () => {
expect(
extractReplyText({
result: {
artifacts: [
{ parts: [{ kind: "text", text: "A" }, { kind: "text", text: "B" }] },
{ parts: [{ kind: "text", text: "C" }] },
],
},
})
).toBe("A\nB\nC");
});
});