fix(tests): correct parse_directives tuple return type in test helper
Some checks failed
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 17s
Handlers Postgres Integration / detect-changes (pull_request) Successful in 22s
CI / Shellcheck (E2E scripts) (pull_request) Successful in 34s
review-check-tests / review-check.sh regression tests (pull_request) Successful in 25s
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 23s
CI / Detect changes (pull_request) Successful in 1m27s
qa-review / approved (pull_request) Failing after 30s
E2E API Smoke Test / detect-changes (pull_request) Successful in 1m24s
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 1m20s
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m30s
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 10s
gate-check-v3 / gate-check (pull_request) Failing after 52s
security-review / approved (pull_request) Failing after 34s
sop-checklist / all-items-acked (pull_request) Successful in 24s
sop-tier-check / tier-check (pull_request) Successful in 22s
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 1m29s
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 12s
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 10s
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 5s
Ops Scripts Tests / Ops scripts (unittest) (pull_request) Successful in 1m36s
CI / Python Lint & Test (pull_request) Successful in 7m34s
CI / Platform (Go) (pull_request) Successful in 10m50s
CI / Canvas (Next.js) (pull_request) Successful in 10m57s
CI / all-required (pull_request) Successful in 10m54s
CI / Canvas Deploy Reminder (pull_request) Successful in 0s
audit-force-merge / audit (pull_request) Waiting to run

PR #1263 changed parse_directives to return (directives, na_directives)
but the test helper was unpacking a list. Also fix test_empty_body
assertions to expect ([], []) not [].

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
Molecule AI · core-be 2026-05-16 04:26:16 +00:00
parent 05ef0964f6
commit 1e294c5930

View File

@ -135,8 +135,8 @@ class TestParseDirectives(unittest.TestCase):
self.aliases = _numeric_aliases()
def parse_ack_revoke(self, body):
# parse_directives now returns list[tuple] (na_directives dropped per PR #1263).
directives = sop.parse_directives(body, self.aliases)
# parse_directives returns (directives, na_directives) per PR #1263.
directives, _na = sop.parse_directives(body, self.aliases)
return directives
def test_simple_ack(self):
@ -201,8 +201,8 @@ class TestParseDirectives(unittest.TestCase):
self.assertEqual(len(d), 1)
def test_empty_body(self):
self.assertEqual(sop.parse_directives("", self.aliases), [])
self.assertEqual(sop.parse_directives(None, self.aliases), [])
self.assertEqual(sop.parse_directives("", self.aliases), ([], []))
self.assertEqual(sop.parse_directives(None, self.aliases), ([], []))
def test_normalization_applied(self):
# /sop-ack Comprehensive_Testing → canonical comprehensive-testing