Merge pull request #2447 from Molecule-AI/chore/wheel-smoke-fixups

chore(smoke-mode): harden module-load + drop dead except clause

workspace/smoke_mode.py

@@ -36,7 +36,13 @@ from typing import Any
 logger = logging.getLogger(__name__)
 
 
-_SMOKE_TIMEOUT_SECS = float(os.environ.get("MOLECULE_SMOKE_TIMEOUT_SECS", "5.0"))
+# Don't crash production boot if MOLECULE_SMOKE_TIMEOUT_SECS is malformed —
+# main.py imports smoke_mode unconditionally (before the is_smoke_mode()
+# check), so a typo'd value would otherwise SystemExit every workspace.
+try:
+    _SMOKE_TIMEOUT_SECS = float(os.environ.get("MOLECULE_SMOKE_TIMEOUT_SECS", "5.0"))
+except ValueError:
+    _SMOKE_TIMEOUT_SECS = 5.0
 
 
 def is_smoke_mode() -> bool:

workspace/tests/test_smoke_mode.py

@@ -33,7 +33,7 @@ def _real_a2a_sdk_available() -> bool:
         from a2a.server.context import ServerCallContext  # noqa: F401
         from a2a.types import SendMessageRequest  # noqa: F401
         return True
-    except (ImportError, AttributeError):
+    except ImportError:
         return False
 
 
@@ -57,6 +57,27 @@ def test_is_smoke_mode_unset(monkeypatch: pytest.MonkeyPatch):
     assert smoke_mode.is_smoke_mode() is False
 
 
+# ─── _SMOKE_TIMEOUT_SECS bad-env-var resilience ────────────────────────
+
+
+def test_smoke_timeout_falls_back_when_env_value_is_malformed(
+    monkeypatch: pytest.MonkeyPatch,
+):
+    """A typo'd MOLECULE_SMOKE_TIMEOUT_SECS must not crash production
+    boot. main.py imports smoke_mode unconditionally — before the
+    is_smoke_mode() check — so float()-at-module-load would SystemExit
+    every workspace if the env value were bad."""
+    import importlib
+    monkeypatch.setenv("MOLECULE_SMOKE_TIMEOUT_SECS", "not-a-float")
+    reloaded = importlib.reload(smoke_mode)
+    try:
+        assert reloaded._SMOKE_TIMEOUT_SECS == 5.0
+    finally:
+        # Restore module to clean default for other tests.
+        monkeypatch.delenv("MOLECULE_SMOKE_TIMEOUT_SECS", raising=False)
+        importlib.reload(smoke_mode)
+
+
 # ─── _build_stub_context (real-SDK-only) ───────────────────────────────