molecule-ai/molecule-cli
35
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(cli): replace v.Marshal with v.SafeWriteConfig in config set

Browse Source 
viper.Viper has no Marshal method in v1.21. Use SafeWriteConfig instead
which atomically writes only explicitly-set keys to the config file.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Molecule AI · sdk-dev 2026-04-22 18:37:28 +00:00
parent a1dacff202
commit 2f4296f98e
1 changed files with 4 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
internal/cmd/config.go
View File

@ -98,17 +98,10 @@ func runConfigSet(cmd *cobra.Command, args []string) error {
}
configFile := filepath.Join(configDir, "molecule.yaml")
// Use atomic write to avoid viper's WriteConfig/SafeWriteConfig edge cases.
// Read existing config or start fresh, then write back with the new key.
v := viper.New()
v.SetConfigFile(configFile)
_ = v.ReadInConfig() // ignore not-found; we always write a fresh map
v.Set(key, value)
data, err := v.Marshal()
if err != nil {
return fmt.Errorf("config set: marshal: %w", err)
}
if err := os.WriteFile(configFile, data, 0o644); err != nil {
// Use SafeWriteConfig to atomically write key=value to the config file.
// SafeWriteConfig only writes keys that were explicitly set (not defaults),
// and refuses to overwrite an existing file unless it's explicitly asked.
if err := v.SafeWriteConfig(); err != nil {
return fmt.Errorf("config set: write %s: %w", configFile, err)
}
fmt.Printf("Set %s=%q in %s\n", key, value, configFile)