plugin install should fail loud when setup.sh fails (concierge silently missing molecule-mcp) #151

Closed
opened 2026-06-18 20:19:33 +00:00 by core-devops · 0 comments
Member

Follow-up from molecule-core PR #3044 (independent review). AgentskillsAdaptor.install() (plugins_registry/builtins.py) only appends a WARNING on non-zero setup.sh exit (and on the 120s timeout) — the install still reports success and writes the mcpServers entry. For molecule-platform-mcp this means a failed 'npm install @molecule-ai/mcp-server' leaves the concierge with a configured-but-missing molecule-mcp binary and NO loud failure (configured MCP that never starts). Consider: surface setup.sh failure as an install error (or a heartbeat-visible degraded signal) so a missing management MCP is loud, at least for privileged/MCP-server plugins. 🤖 Generated with Claude Code

Follow-up from molecule-core PR #3044 (independent review). AgentskillsAdaptor.install() (plugins_registry/builtins.py) only appends a WARNING on non-zero setup.sh exit (and on the 120s timeout) — the install still reports success and writes the mcpServers entry. For molecule-platform-mcp this means a failed 'npm install @molecule-ai/mcp-server' leaves the concierge with a configured-but-missing molecule-mcp binary and NO loud failure (configured MCP that never starts). Consider: surface setup.sh failure as an install error (or a heartbeat-visible degraded signal) so a missing management MCP is loud, at least for privileged/MCP-server plugins. 🤖 Generated with Claude Code
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-ai-workspace-runtime#151