fix(skill): clarify Phase 4 wording + add validate-plugin CI gate #1

claude-ceo-assistant · 2026-05-08T13:20:02Z

2026-05-08 13:20:02 +00:00

Five-axis self-review on v1.0.0 caught two Required findings — Phase 4 wording contradiction with dev-sop.md, and missing validate-plugin CI gate that every sibling plugin has. Plus an Optional improvement: replaced angle-bracket-placeholder output template with a concrete worked example using the real findings from the !external resolver work.

Full rationale in the commit message.

Five-axis self-review on v1.0.0 caught two Required findings — Phase 4 wording contradiction with dev-sop.md, and missing validate-plugin CI gate that every sibling plugin has. Plus an Optional improvement: replaced angle-bracket-placeholder output template with a concrete worked example using the real findings from the !external resolver work. Full rationale in the commit message.

claude-ceo-assistant added 1 commit 2026-05-08 13:20:02 +00:00

fix(skill): clarify Phase 4 wording + add validate-plugin CI gate

CI / validate (push) Successful in 56s

Details

CI / validate (pull_request) Successful in 59s

Details

8d88f3ebf4

Five-axis self-review on the v1.0.0 scaffold caught two Required-severity
findings:

1. CORRECTNESS — SKILL.md 'When to invoke' said 'before Phase 4
   verification publishes the change', but dev-sop.md treats Phase 4 AS
   the self-review (with verification as a sub-step). Internally
   contradictory between the two docs shipped together. Tightened the
   wording: this skill IS the Phase 4 procedure; verification chain
   takes over after the skill's output goes into the PR description.

2. ARCHITECTURE — Plugin repo was missing the validate-plugin reusable
   workflow that every sibling plugin (e.g. molecule-skill-code-review)
   calls. Without it, manifest-shape regressions ship silently. Added
   .github/workflows/ci.yml invoking
   molecule-ai/molecule-ci/.github/workflows/validate-plugin.yml@main —
   one-line file, parity with siblings.

Also took an Optional finding while there: SKILL.md output template
showed angle-bracket placeholders and '(or)' meta-prefixes that an agent
following the example literally might paste verbatim. Replaced the
abstract template with a concrete worked example (using the real
findings from the !external resolver work that drove this skill's
existence: cache validity, token persistence, naming). Self-documenting.

WHY THE STRUCTURED REVIEW CAUGHT THESE
  Both findings would have shipped silently with a 3-weakest pass on
  the same code — the contradiction is between two files and you'd have
  to read them adjacent to each other; the missing CI gate isn't visible
  in either file's diff. The Architecture axis caught the gate gap by
  asking 'follows existing patterns? sibling plugins all have one'.
  The Correctness axis caught the wording by asking 'does this match
  the spec?' and reading dev-sop.md's actual Phase 4 definition.

REFS
  v1.0.0 ship — internal#85 (RFC), internal#84 (SOP doc PR)
  Sibling plugin shape — molecule-skill-code-review

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

claude-ceo-assistant merged commit eca4c2511c into main

2026-05-08 13:20:23 +00:00

claude-ceo-assistant referenced this issue from a commit

2026-05-08 13:20:24 +00:00

Merge pull request 'fix(skill): clarify Phase 4 wording + add validate-plugin CI gate' (#1) from fix/phase4-wording-and-ci-gate into main

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No project

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-ai-plugin-molecule-skill-five-axis-review#1