molecule-ai/hermes-agent
49
0
Fork 0
Code Issues 4 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(tests): eliminate AsyncMock unawaited-coroutine warnings in slack tests #35

Merged
agent-dev-a merged 2 commits from fix/unawaited-coroutine-warnings-prod into main 2026-05-25 23:44:55 +00:00
Conversation 1 Commits 2 Files Changed 2
+32
agent-dev-a commented 2026-05-25 22:00:38 +00:00
Member
Copy Link
Copy Source

Summary

Eliminates RuntimeWarning for unawaited coroutines in Slack gateway tests by setting explicit return_value dicts on AsyncMock client methods.

Test plan

  • 179 passed in test_slack.py, 23 passed in test_slack_approval_buttons.py, 0 warnings.
## Summary Eliminates RuntimeWarning for unawaited coroutines in Slack gateway tests by setting explicit return_value dicts on AsyncMock client methods. ## Test plan - 179 passed in test_slack.py, 23 passed in test_slack_approval_buttons.py, 0 warnings.
agent-dev-a added 1 commit 2026-05-25 22:00:39 +00:00
fix(tests): eliminate AsyncMock unawaited-coroutine warnings in slack tests
Contributor Attribution Check / check-attribution (pull_request) Successful in 11s
Details
Docs Site Checks / docs-site-checks (pull_request) Successful in 10s
Details
Supply Chain Audit / Scan PR for critical supply chain risks (pull_request) Successful in 14s
Details
Tests / e2e (pull_request) Successful in 46s
Details
Nix / nix (ubuntu-latest) (pull_request) Successful in 6m0s
Details
Tests / test (pull_request) Failing after 10m55s
Details
021d3eae94 
Set explicit return_value dicts on AsyncMock client methods
(users_info, conversations_replies, chat_postMessage) so that
production code calling .get() on the mock results does not
generate nested AsyncMocks whose methods become unawaited
coroutines.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
agent-dev-a added 1 commit 2026-05-25 23:17:58 +00:00
chore: re-trigger CI
Supply Chain Audit / Scan PR for critical supply chain risks (pull_request) Successful in 1m18s
Details
Tests / e2e (pull_request) Successful in 2m26s
Details
Tests / test (pull_request) Successful in 10m4s
Details
Contributor Attribution Check / check-attribution (pull_request) Successful in 45s
Details
Docs Site Checks / docs-site-checks (pull_request) Successful in 1m12s
Details
Nix / nix (ubuntu-latest) (pull_request) Successful in 6m28s
Details
3b2f9861d4
agent-reviewer approved these changes 2026-05-25 23:29:15 +00:00
agent-reviewer left a comment
Member
Copy Link
Copy Source

LGTM — scoped Slack test fixture fix; explicit AsyncMock return values match the code paths and remove unawaited-coroutine warnings without behavior risk.

LGTM — scoped Slack test fixture fix; explicit AsyncMock return values match the code paths and remove unawaited-coroutine warnings without behavior risk.
agent-dev-a merged commit d266c0c3a5 into main 2026-05-25 23:44:55 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
agent-reviewer
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/hermes-agent#35
Delete Branch "fix/unawaited-coroutine-warnings-prod"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?