From 0bb8d8faf562d340963bb250e5f7d9830c001896 Mon Sep 17 00:00:00 2001
From: darya <137614867+cutepawss@users.noreply.github.com>
Date: Thu, 26 Feb 2026 17:45:50 +0300
Subject: [PATCH] fix: prevent silent abort in piped install when interactive
 prompts fail (#69)

Root cause: the install script uses `set -e` (exit on error) and `read -p`
for interactive prompts. When running via `curl | bash`, stdin is a pipe
(not a terminal), so `read -p` hits EOF and returns exit code 1. Under
`set -e`, this silently aborts the entire script before hermes is installed.

Fix: detect non-interactive mode using `[ -t 0 ]` (standard POSIX test for
terminal stdin) and skip all interactive prompts when running in piped mode.
Clear messages are shown instead, telling the user what to run manually.

Changes:
- Add IS_INTERACTIVE flag at script start ([ -t 0 ] check)
- Guard sudo package install prompt (the direct cause of #69)
- Guard setup wizard (calls interactive hermes setup)
- Guard WhatsApp pairing and gateway install prompts

All other prompts use the same read -p pattern and would fail the same way
in piped mode, so they are all guarded for completeness.

Closes #69
---
 scripts/install.sh | 64 +++++++++++++++++++++++++++++++++-------------
 1 file changed, 46 insertions(+), 18 deletions(-)

diff --git a/scripts/install.sh b/scripts/install.sh
index 4d3a2b7d..4f7effe0 100755
--- a/scripts/install.sh
+++ b/scripts/install.sh
@@ -38,6 +38,15 @@ USE_VENV=true
 RUN_SETUP=true
 BRANCH="main"
 
+# Detect non-interactive mode (e.g. curl | bash)
+# When stdin is not a terminal, read -p will fail with EOF,
+# causing set -e to silently abort the entire script.
+if [ -t 0 ]; then
+    IS_INTERACTIVE=true
+else
+    IS_INTERACTIVE=false
+fi
+
 # Parse arguments
 while [[ $# -gt 0 ]]; do
     case $1 in
@@ -467,15 +476,20 @@ install_system_packages() {
             fi
         # sudo needs password — ask once for everything
         elif command -v sudo &> /dev/null; then
-            echo ""
-            read -p "Install ${description}? (requires sudo) [y/N] " -n 1 -r
-            echo
-            if [[ $REPLY =~ ^[Yy]$ ]]; then
-                if sudo $install_cmd; then
-                    [ "$need_ripgrep" = true ] && HAS_RIPGREP=true && log_success "ripgrep installed"
-                    [ "$need_ffmpeg" = true ]  && HAS_FFMPEG=true  && log_success "ffmpeg installed"
-                    return 0
+            if [ "$IS_INTERACTIVE" = true ]; then
+                echo ""
+                read -p "Install ${description}? (requires sudo) [y/N] " -n 1 -r
+                echo
+                if [[ $REPLY =~ ^[Yy]$ ]]; then
+                    if sudo $install_cmd; then
+                        [ "$need_ripgrep" = true ] && HAS_RIPGREP=true && log_success "ripgrep installed"
+                        [ "$need_ffmpeg" = true ]  && HAS_FFMPEG=true  && log_success "ffmpeg installed"
+                        return 0
+                    fi
                 fi
+            else
+                log_warn "Non-interactive mode: cannot prompt for sudo password"
+                log_info "Install missing packages manually: sudo $install_cmd"
             fi
         fi
     fi
@@ -771,6 +785,11 @@ run_setup_wizard() {
         return 0
     fi
 
+    if [ "$IS_INTERACTIVE" = false ]; then
+        log_info "Setup wizard skipped (non-interactive). Run 'hermes setup' after install."
+        return 0
+    fi
+
     echo ""
     log_info "Starting setup wizard..."
     echo ""
@@ -813,19 +832,28 @@ maybe_start_gateway() {
     WHATSAPP_VAL=$(grep "^WHATSAPP_ENABLED=" "$ENV_FILE" 2>/dev/null | cut -d'=' -f2-)
     WHATSAPP_SESSION="$HERMES_HOME/whatsapp/session/creds.json"
     if [ "$WHATSAPP_VAL" = "true" ] && [ ! -f "$WHATSAPP_SESSION" ]; then
-        echo ""
-        log_info "WhatsApp is enabled but not yet paired."
-        log_info "Running 'hermes whatsapp' to pair via QR code..."
-        echo ""
-        read -p "Pair WhatsApp now? [Y/n] " -n 1 -r
-        echo
-        if [[ $REPLY =~ ^[Yy]$ ]] || [[ -z $REPLY ]]; then
-            HERMES_CMD="$HOME/.local/bin/hermes"
-            [ ! -x "$HERMES_CMD" ] && HERMES_CMD="hermes"
-            $HERMES_CMD whatsapp || true
+        if [ "$IS_INTERACTIVE" = true ]; then
+            echo ""
+            log_info "WhatsApp is enabled but not yet paired."
+            log_info "Running 'hermes whatsapp' to pair via QR code..."
+            echo ""
+            read -p "Pair WhatsApp now? [Y/n] " -n 1 -r
+            echo
+            if [[ $REPLY =~ ^[Yy]$ ]] || [[ -z $REPLY ]]; then
+                HERMES_CMD="$HOME/.local/bin/hermes"
+                [ ! -x "$HERMES_CMD" ] && HERMES_CMD="hermes"
+                $HERMES_CMD whatsapp || true
+            fi
+        else
+            log_info "WhatsApp pairing skipped (non-interactive). Run 'hermes whatsapp' to pair."
         fi
     fi
 
+    if [ "$IS_INTERACTIVE" = false ]; then
+        log_info "Gateway setup skipped (non-interactive). Run 'hermes gateway install' later."
+        return 0
+    fi
+
     echo ""
     read -p "Would you like to install the gateway as a background service? [Y/n] " -n 1 -r
     echo