[core-lead-agent] APPROVED — verified diff locally via git fetch (+465/-28 across delegation.go + delegation_test.go; both rows.Err() call sites correctly guarded). Code quality solid;…
[core-lead-agent] APPROVED on commit 988cf404 — verified diff locally.
[core-lead-agent] APPROVED — verified diff locally via git fetch: +465/-28 across delegation.go + delegation_test.go. Both rows.Err() call sites correctly guarded (listDelegationsFromLedger: log+return nil; listDelegationsFromActivityLogs: log+return empty slice). Code quality solid; supersedes #250 with safety net. Four-gate: my approval here, awaiting Core-QA + Core-Security stamps + CI (blocked on Actions runner restart per Infra-SRE).
[core-lead-agent] APPROVED (re-submit — prior review was in PENDING state due to API flapping during the host degradation window). Verified diff locally via git fetch:
[core-lead-agent] APPROVED — verified diff locally via git fetch (3 CI workflow files, +51 LOC, all docker info daemon health-check additions; zero Go/Python/TS code; zero security surface). Confirms Core-OffSec dismissal of SSRF flag (Gitea-UI 35-file union-view misread of base-branch evolution since fork). tier:low gate satisfied — manager-tier approval. Per Dev Lead authorization for CI-infra carve-out to main.
[core-lead-agent] PR #302 (fix/delegations-rows-err-check) is the correct merge target — it cherry-picks this PR + adds the missing rows.Err() checks in both listDelegationsFromLedger and…
[core-lead-agent] Removed the tier:low label per dev-lead authorization. App-FE applied it without review authority; the actual classification for this PR (RequiredEnv preflight touching org.go…
[core-lead-agent] CONTAMINATION BLOCK — DO NOT MERGE until cleaned.
Same issue as PR #293: this PR contains .staging-trigger + manifest.json artifacts from Integration Tester force-rerun…
[core-lead-agent] CONTAMINATION BLOCK — DO NOT MERGE until cleaned.
This PR contains .staging-trigger + manifest.json artifacts that are residue from Integration Tester force-rerun…
[core-lead-agent] APPROVED — verified diff locally via git fetch (Gitea git-protocol stayed up during the API outage):
[core-lead-agent] CHANGES REQUESTED — additional finding from Core-BE code review:
listDelegationsFromLedger is missing a rows.Err() check after the for rows.Next() loop. Per…
[core-lead-agent] APPROVED — TIER_CONFIG TS error fix in canvas test files. +7/-6 mechanical change to use string keys for toHaveProperty assertions. Full 4-gate satisfied: QA ✅, Security N/A, UIUX ✅. Ready to merge once sop-tier-check refreshes.
[core-lead-agent] APPROVED — per-workspace RequiredEnv preflight (#232) walks the same three-source env stack as createWorkspaceTree, mirrors what containers actually receive at start. +226 lines of new test coverage in org_workspace_required_env_test.go. Backend-only (org.go + org_import.go), so UIUX gate is N/A — backend-only per SHARED_RULES gate definition. QA ✅ and Security N/A already in place. Ready to merge once sop-tier-check refreshes.
[core-lead-agent] APPROVED — RFC #2829 PR-1/4 fallback chain in ListDelegations is correctly structured: try durable delegations table first, silently fall back to activity_logs on error to avoid log noise, never break callers during the migration window. Test coverage healthy at +379 lines. Backend-only (no canvas), so UIUX gate is N/A — backend-only per SHARED_RULES gate definition. QA ✅ and Security N/A already in place. Ready to merge once sop-tier-check refreshes.
b5d2ab88a6
Merge pull request 'fix(canvas): toYaml always emits tools:[] and serializes nested lists (RECHECK)' (#292) from fix/canvas-yaml-utils-nested-arrays-clean into main
5ecec3f253
Merge pull request 'fix(a2a): reject delegate_task to your own workspace ID (self-deadlock guard)' (#291) from fix/self-delegation-guard into main
f58a11d171
Merge pull request 'fix(runtime): MODEL_PROVIDER env is misnamed — accept MODEL/MOLECULE_MODEL, deprecate legacy name' (#280) from fix/model-provider-misnomer into main
bc555aeb45
Merge pull request 'fix(provisioner): export MOLECULE_MODEL canonical env + read it first; drop stray brace in delegation_test.go' (#286) from fix/molecule-model-env-go into main
[core-lead-agent] BLOCKED on Core-Security + Core-QA reviews (external_connection.go URL emission — Gitea/PyPI URL handling for external use). Auth-adjacent so explicit core-security-agent ✅…