History

Hongming Wang f8ba8a2847 chore: apply code-review round-6 suggestions All 5 suggestions from the latest review pass. ## tests/e2e/_extract_token.py (new) Extracted the 14-line python-in-bash heredoc from _lib.sh into a real Python file. Easier to edit, fewer escaping traps, same behavior. Shell helper now just shells out to it. ## tests/e2e/_lib.sh - Replaced inline python with: python3 "$(dirname "${BASH_SOURCE[0]}")/_extract_token.py" - Removed redundant sys.exit(0) as part of the extraction ## Shellcheck-clean scripts (new CI job enforces) - Removed dead captures: BEFORE_COUNT (test_activity_e2e.sh), ORIG_SKILLS, REIMPORT_SKILLS (test_api.sh), QA_TOKEN (test_comprehensive_e2e.sh) - Renamed unused loop vars `i`, `j` -> `_` in 4 sites - Added `# shellcheck disable=SC2046` on the two intentional word-splits in test_claude_code_e2e.sh (docker stop/rm of multiple container IDs) - Removed a useless re-register of QA mid-script (was done in Section 2) ## CI (.github/workflows/ci.yml) - Replaced `sudo apt-get install postgresql-client` + psql with a direct `docker exec` into the existing postgres:16 service container. Saves ~10-20s per CI run. - Added new `shellcheck` job that lints tests/e2e/.sh on every PR. Local: shellcheck --severity=warning returns 0 across all 5 scripts. ## Verification - go test -race ./internal/handlers/... : pass - mcp-server: 96/96 jest - canvas: 357/357 vitest + clean build - tests/e2e/test_api.sh: 62/62 - tests/e2e/test_comprehensive_e2e.sh: 67/67 - shellcheck tests/e2e/.sh : clean - CI YAML: valid Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>	2026-04-13 17:08:45 -07:00
..
e2e	chore: apply code-review round-6 suggestions	2026-04-13 17:08:45 -07:00
README.md	chore: structural cleanup — dead dirs, moves, gitignore	2026-04-13 14:06:52 -07:00

Hongming Wang f8ba8a2847 chore: apply code-review round-6 suggestions

All 5 suggestions from the latest review pass.

## tests/e2e/_extract_token.py (new)
Extracted the 14-line python-in-bash heredoc from _lib.sh into a real
Python file. Easier to edit, fewer escaping traps, same behavior.
Shell helper now just shells out to it.

## tests/e2e/_lib.sh
- Replaced inline python with: python3 "$(dirname "${BASH_SOURCE[0]}")/_extract_token.py"
- Removed redundant sys.exit(0) as part of the extraction

## Shellcheck-clean scripts (new CI job enforces)
- Removed dead captures: BEFORE_COUNT (test_activity_e2e.sh), ORIG_SKILLS,
  REIMPORT_SKILLS (test_api.sh), QA_TOKEN (test_comprehensive_e2e.sh)
- Renamed unused loop vars `i`, `j` -> `_` in 4 sites
- Added `# shellcheck disable=SC2046` on the two intentional word-splits
  in test_claude_code_e2e.sh (docker stop/rm of multiple container IDs)
- Removed a useless re-register of QA mid-script (was done in Section 2)

## CI (.github/workflows/ci.yml)
- Replaced `sudo apt-get install postgresql-client` + psql with a direct
  `docker exec` into the existing postgres:16 service container. Saves
  ~10-20s per CI run.
- Added new `shellcheck` job that lints tests/e2e/*.sh on every PR.
  Local: shellcheck --severity=warning returns 0 across all 5 scripts.

## Verification
- go test -race ./internal/handlers/... : pass
- mcp-server: 96/96 jest
- canvas: 357/357 vitest + clean build
- tests/e2e/test_api.sh: 62/62
- tests/e2e/test_comprehensive_e2e.sh: 67/67
- shellcheck tests/e2e/*.sh : clean
- CI YAML: valid

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

2026-04-13 17:08:45 -07:00

e2e

chore: apply code-review round-6 suggestions

2026-04-13 17:08:45 -07:00

README.md

chore: structural cleanup — dead dirs, moves, gitignore

2026-04-13 14:06:52 -07:00

README.md

Tests

This repo uses the standard monorepo testing convention: unit tests live with their package, cross-component E2E tests live here.

Where to find tests

Scope	Location
Go unit + integration (platform, CLI, handlers)	`platform/*/_test.go` — run with `cd platform && go test -race ./...`
TypeScript unit (canvas components, hooks, store)	`canvas/src/**/__tests__/` — run with `cd canvas && npm test -- --run`
TypeScript unit (MCP server handlers)	`mcp-server/src/__tests__/` — run with `cd mcp-server && npx jest`
Python unit (workspace runtime, adapters)	`workspace-template/tests/` — run with `cd workspace-template && python3 -m pytest`
Python unit (SDK: plugin + remote agent)	`sdk/python/tests/` — run with `cd sdk/python && python3 -m pytest`
Cross-component E2E (spans platform + runtime + HTTP)	`tests/e2e/` ← you are here

Why split this way

Go requires co-located _test.go files to access unexported symbols.
Per-package test commands keep the inner loop fast — changing canvas doesn't re-run Go tests.
tests/e2e/ covers scenarios that no single package owns: a full workspace lifecycle, A2A across two provisioned agents, delegation chains, bundle round-trips.

Running E2E

Every E2E script here assumes the platform is running at localhost:8080 and (where noted) provisioned agents are online. See the header comment of each .sh for specifics.