molecule-core/workspace-server/internal
Hongming Wang df2cf935d3 fix(handlers): validate path/auth BEFORE docker availability checks
Three traversal / cross-workspace rejection tests on staging were
masked by premature "docker not available" early returns:

1. deleteViaEphemeral — nil-docker check fired BEFORE path validation;
   malicious paths got "docker not available" (wrong code path) instead
   of "path not allowed". Reversed the order + added "path not allowed:"
   prefix to rejection messages.

2. copyFilesToContainer — split the traversal classifier into:
   - absolute path → "unsafe file path in archive"
   - literal "../" prefix → "unsafe file path in archive" (classic)
   - URL-encoded / mid-path traversal → "path escapes destination"
   Added nil-docker guard AFTER validation so legitimate inputs error
   cleanly instead of panicking on nil docker.

3. HandleConnect KI-005 — test used outdated table name
   "workspace_tokens"; ValidateAnyToken uses "workspace_auth_tokens"
   since #1210. Updated the mock. Added best-effort last_used_at
   UPDATE expectation that fires after successful token validation.

Brings the handlers package from 3 failing tests to 0. All 20 Go
packages green on go test -race ./... locally.
2026-04-23 09:31:54 -07:00
..
artifacts test(handlers): add CWE-22 regression suite + KI-005 terminal access fix + tests (#1574) 2026-04-22 15:30:11 +00:00
bundle fix(platform): unblock SaaS workspace registration end-to-end 2026-04-21 03:06:46 -07:00
channels test(handlers): add CWE-22 regression suite + KI-005 terminal access fix + tests (#1574) 2026-04-22 15:30:11 +00:00
crypto chore: open-source restructure — rename dirs, remove internal files, scrub secrets 2026-04-18 00:24:44 -07:00
db test: schema_migrations tracking — 4 cases (first boot, re-boot, mixed, down.sql filter) 2026-04-18 11:52:27 -07:00
envx chore: open-source restructure — rename dirs, remove internal files, scrub secrets 2026-04-18 00:24:44 -07:00
events chore: open-source restructure — rename dirs, remove internal files, scrub secrets 2026-04-18 00:24:44 -07:00
handlers fix(handlers): validate path/auth BEFORE docker availability checks 2026-04-23 09:31:54 -07:00
metrics chore: open-source restructure — rename dirs, remove internal files, scrub secrets 2026-04-18 00:24:44 -07:00
middleware fix(platform-go-ci): align test mocks with schema drift + org_id context contract (#1755) 2026-04-23 07:14:33 +00:00
models fix: CWE-78 rm scope, go vet failures, delegation idempotency 2026-04-21 18:22:30 +00:00
orgtoken fix(platform-go-ci): align test mocks with schema drift + org_id context contract (#1755) 2026-04-23 07:14:33 +00:00
plugins chore: open-source restructure — rename dirs, remove internal files, scrub secrets 2026-04-18 00:24:44 -07:00
provisioner fix(cp-provisioner): use CP_ADMIN_API_TOKEN bearer for /cp/admin/* routes 2026-04-22 17:13:38 -07:00
registry fix(sweeper): emit WORKSPACE_PROVISION_FAILED so canvas updates UI 2026-04-20 20:38:41 -07:00
router fix(review): address code review blockers on tool-trace + instructions 2026-04-22 16:18:06 -07:00
scheduler feat(scheduler): sweepPhantomBusy — clear stuck active_tasks from crashed runs (extracted from #1664) 2026-04-22 19:57:49 -07:00
supervised chore: open-source restructure — rename dirs, remove internal files, scrub secrets 2026-04-18 00:24:44 -07:00
ws chore: open-source restructure — rename dirs, remove internal files, scrub secrets 2026-04-18 00:24:44 -07:00
wsauth chore: open-source restructure — rename dirs, remove internal files, scrub secrets 2026-04-18 00:24:44 -07:00