forked from molecule-ai/molecule-core
f1792e1f7a
The sweep-cf-orphans workflow shipped in #2088 was noisier than intended in two ways. This PR fixes both — was filed under the Optional finding I left on the original review and now matters because the noise is observably hitting the merge queue. 1) `merge_group: types: [checks_requested]` was firing the entire sweep job on every PR through the merge queue. The original intent ("future required-check support without a workflow edit") never materialized, and meanwhile every recent merge-queue eval (#2091, #2092, #2093, #2094, #2095, #2097) generated a red `Sweep CF orphans (merge_group)` run. Drop the trigger. Comment in the workflow explains the re-add path if/when the workflow IS wired as a required check (re-add the trigger AND gate the actual sweep step with `if: github.event_name != 'merge_group'` so merge-queue evals are no-op success). 2) The `Verify required secrets present` step exits 2 when the 6 secrets aren't configured yet (the PR body's post-merge step, still pending). That turns the hourly schedule into an hourly red CI run for as long as the secrets stay unset. Convert to a soft skip: emit a `:⚠️:` listing the missing secrets and set a `skip=true` step output, then gate the sweep step with `if: steps.verify.outputs.skip != 'true'`. Workflow reports green and ops still sees the warning when they review recent runs. Net effect: - merge-queue evals stop generating spurious red runs - the schedule reports green-with-warning until secrets land - once secrets land, behavior is identical to today's (real sweep runs, hard-fails if a secret is later removed) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| auto-promote-staging.yml | ||
| block-internal-paths.yml | ||
| canary-staging.yml | ||
| canary-verify.yml | ||
| check-merge-group-trigger.yml | ||
| ci.yml | ||
| codeql.yml | ||
| e2e-api.yml | ||
| e2e-staging-canvas.yml | ||
| e2e-staging-saas.yml | ||
| e2e-staging-sanity.yml | ||
| promote-latest.yml | ||
| publish-canvas-image.yml | ||
| publish-workspace-server-image.yml | ||
| redeploy-tenants-on-main.yml | ||
| retarget-main-to-staging.yml | ||
| runtime-pin-compat.yml | ||
| sweep-cf-orphans.yml | ||
| sweep-stale-e2e-orgs.yml | ||
| test-ops-scripts.yml | ||