forked from molecule-ai/molecule-core
Preparation for a "hundreds of runtimes" plugin ecosystem. Keeping the
runtime-specific UX knobs in-line inside ProvisioningTimeout scales badly
— every new runtime would require editing a component, not just adding a
table entry. Other components (create-workspace dialog, workspace card
tooltips, etc.) will want the same runtime metadata.
Changes:
- New file `canvas/src/lib/runtimeProfiles.ts` owns:
* `RuntimeProfile` type — structural shape, every field optional so
new runtimes can partially-fill without breaking consumers.
* `DEFAULT_RUNTIME_PROFILE` — 2-min default floor (docker-fast).
* `RUNTIME_PROFILES` — named overrides (currently: hermes 12 min).
* `WorkspaceRuntimeOverrides` — interface for server-provided
per-workspace overrides, so operators can tune via template
manifest / workspace metadata without a canvas release.
* `getRuntimeProfile()` — resolver with
overrides → profile → default priority.
* `provisionTimeoutForRuntime()` — convenience wrapper.
- `ProvisioningTimeout.tsx` now delegates to the profile module.
`DEFAULT_PROVISION_TIMEOUT_MS` re-exported for legacy test importers.
- Tests: 16/16 (up from 9 before the first fix). Adds pinning for:
* overrides > profile > default priority chain
* "every entry in RUNTIME_PROFILES resolves to a number" contract
* backward-compat export
Adding a new slow runtime is now one table entry in
`canvas/src/lib/runtimeProfiles.ts` with a mandatory `WHY` comment.
Moving to server-driven profiles later is a ~10-line change (the
resolver already threads WorkspaceRuntimeOverrides through).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
121 lines
4.5 KiB
TypeScript
121 lines
4.5 KiB
TypeScript
/**
|
|
* Runtime profiles — per-runtime UX metadata.
|
|
*
|
|
* Scaling target: hundreds of runtimes (plugin-architecture-v2 roadmap).
|
|
* This module is the single source of truth for runtime-specific UI knobs
|
|
* on the canvas side. Each runtime can declare:
|
|
*
|
|
* - provisionTimeoutMs: when to show the "taking longer than expected"
|
|
* banner. Fast docker runtimes = 2min; slow source-build runtimes = 12min.
|
|
* - (future) label, icon, color, helpUrl, capabilities — add as needed.
|
|
*
|
|
* Resolution order (most specific wins):
|
|
*
|
|
* 1. Server-provided override on the workspace data (e.g.
|
|
* `workspace.data.provisionTimeoutMs` set from a template manifest).
|
|
* Lets operators tune without a canvas release once server-side
|
|
* declarative config lands.
|
|
* 2. Per-runtime entry in RUNTIME_PROFILES.
|
|
* 3. DEFAULT_RUNTIME_PROFILE.
|
|
*
|
|
* Adding a new runtime:
|
|
* - If it's fast (≤ 2min cold boot): do nothing, the default catches it.
|
|
* - If it's slow: add one entry to RUNTIME_PROFILES below.
|
|
* - Long-term: move runtime profiles server-side so this file can shrink.
|
|
*
|
|
* Architectural note: this deliberately lives under /lib, NOT
|
|
* /components/ProvisioningTimeout. Other components (e.g. a
|
|
* "create workspace" dialog that needs to know the runtime's expected
|
|
* cold-boot time) should import from here too — avoids duplicating the
|
|
* runtime-name knowledge across the codebase.
|
|
*/
|
|
|
|
/**
|
|
* Structural shape of a runtime profile. Add fields as new UX knobs
|
|
* become runtime-specific. Every field should be optional so new runtimes
|
|
* can partially fill the profile without breaking older code that reads
|
|
* only some fields.
|
|
*/
|
|
export interface RuntimeProfile {
|
|
/** Milliseconds before the canvas shows the "taking too long" banner.
|
|
* Base value — the ProvisioningTimeout component still scales this by
|
|
* concurrent-provisioning count. */
|
|
provisionTimeoutMs?: number;
|
|
// Future extensions (kept commented until used):
|
|
// label?: string;
|
|
// icon?: string;
|
|
// color?: string;
|
|
// helpUrl?: string;
|
|
}
|
|
|
|
/** The floor every runtime inherits unless it overrides. Calibrated for
|
|
* docker-local fast runtimes (claude-code, langgraph, crewai) where cold
|
|
* boot is 30-90s. */
|
|
export const DEFAULT_RUNTIME_PROFILE: Required<
|
|
Pick<RuntimeProfile, "provisionTimeoutMs">
|
|
> = {
|
|
provisionTimeoutMs: 120_000, // 2 min
|
|
};
|
|
|
|
/**
|
|
* Named per-runtime overrides. Keep this map small and explicit —
|
|
* each entry is a deliberate statement that this runtime's cold-boot
|
|
* behavior differs materially from the default.
|
|
*
|
|
* Each override must also ship with a comment explaining WHY the default
|
|
* is wrong for this runtime. Unexplained numbers rot.
|
|
*/
|
|
export const RUNTIME_PROFILES: Record<string, RuntimeProfile> = {
|
|
hermes: {
|
|
// 12 min. Installs ripgrep + ffmpeg + node22 + builds hermes-agent
|
|
// from source + Playwright + Chromium (~300MB download). Measured
|
|
// cold boots on staging EC2 routinely land at 8-13 min. Aligns
|
|
// with SaaS E2E's PROVISION_TIMEOUT_SECS=900 (15 min) so the UI
|
|
// warning lands shortly before the backend itself gives up.
|
|
provisionTimeoutMs: 720_000,
|
|
},
|
|
};
|
|
|
|
/**
|
|
* Data fields the canvas can consult for per-workspace overrides. These
|
|
* let the backend (via workspace data on the socket payload) override
|
|
* profile values without a canvas release.
|
|
*
|
|
* Intentionally loose typing — if a field isn't present on the node, we
|
|
* fall through to the runtime profile.
|
|
*/
|
|
export interface WorkspaceRuntimeOverrides {
|
|
provisionTimeoutMs?: number;
|
|
}
|
|
|
|
/**
|
|
* Resolve a runtime profile for a given runtime name, optionally merging
|
|
* server-provided per-workspace overrides on top.
|
|
*
|
|
* Resolution (most-specific wins):
|
|
* overrides.provisionTimeoutMs
|
|
* → RUNTIME_PROFILES[runtime].provisionTimeoutMs
|
|
* → DEFAULT_RUNTIME_PROFILE.provisionTimeoutMs
|
|
*/
|
|
export function getRuntimeProfile(
|
|
runtime: string | undefined,
|
|
overrides?: WorkspaceRuntimeOverrides,
|
|
): Required<Pick<RuntimeProfile, "provisionTimeoutMs">> {
|
|
const profile = runtime ? RUNTIME_PROFILES[runtime] : undefined;
|
|
return {
|
|
provisionTimeoutMs:
|
|
overrides?.provisionTimeoutMs ??
|
|
profile?.provisionTimeoutMs ??
|
|
DEFAULT_RUNTIME_PROFILE.provisionTimeoutMs,
|
|
};
|
|
}
|
|
|
|
/** Convenience: just the provisionTimeoutMs. Equivalent to
|
|
* `getRuntimeProfile(runtime, overrides).provisionTimeoutMs`. */
|
|
export function provisionTimeoutForRuntime(
|
|
runtime: string | undefined,
|
|
overrides?: WorkspaceRuntimeOverrides,
|
|
): number {
|
|
return getRuntimeProfile(runtime, overrides).provisionTimeoutMs;
|
|
}
|