forked from molecule-ai/molecule-core
fix(workspace): set git user.name/email from $GITEA_USER at boot
Closes #155. Without this, every commit from a workspace booted via the standard provisioner lands with an empty `user.name`/`user.email` and Gitea attributes the work to whichever PAT pushed (typically the founder's `claude-ceo-assistant`), instead of the persona that actually authored the commit. That's the same fingerprint pattern that got us suspended on GitHub 2026-05-06. GITEA_USER is already injected per-workspace by the provisioner from workspace_secrets (verified: 8/8 Core-* workspaces have it set, correctly-named, on operator + local). Boot picks it up unconditionally; falls through cleanly if unset (e.g. legacy boxes without persona identity wiring). Email uses `bot.moleculesai.app` so agent commits are visually distinct from human-authored commits in Gitea history. The `gitconfig` copy from `/root/.gitconfig` to `/home/agent/.gitconfig` is now unconditional — previously it was nested inside the `molecule-git-token-helper.sh` block, which meant the per-persona identity wouldn't propagate to the agent user when the helper was unavailable. Also added an inline note that the github.com credential-helper block is post-suspension legacy. Full removal tracked under #171; this PR deliberately doesn't touch it (smaller blast radius). Tested: docker exec sets the same config in 8 running Core-* workspaces locally and they pick up correct identity for `git config -l`. Will reset when those containers restart, hence this PR for the persistent fix.
This commit is contained in:
parent
4b074f631b
commit
a4fc04189c
@ -43,11 +43,29 @@ if [ "$(id -u)" = "0" ]; then
|
||||
ln -sfn /root/.claude/sessions /home/agent/.claude/sessions
|
||||
fi
|
||||
|
||||
# --- Per-persona git identity (closes molecule-core#155) ---
|
||||
# Without this, every team commit lands with an empty author and Gitea
|
||||
# attributes the work to the founder PAT instead of the persona that
|
||||
# actually authored it. Same fingerprint that got us suspended on GitHub
|
||||
# 2026-05-06. GITEA_USER is injected by the provisioner from the
|
||||
# workspace_secrets table; bot.moleculesai.app is the agent-only domain
|
||||
# so commits are clearly distinguishable from human authors.
|
||||
if [ -n "${GITEA_USER:-}" ]; then
|
||||
git config --global user.name "${GITEA_USER}"
|
||||
git config --global user.email "${GITEA_USER}@bot.moleculesai.app"
|
||||
fi
|
||||
|
||||
# --- GitHub credential helper setup (issue #547 / #613) ---
|
||||
# Configure git to use the molecule credential helper for github.com.
|
||||
# This runs as root so the global gitconfig is written before we drop
|
||||
# to agent. The helper fetches fresh GitHub App installation tokens
|
||||
# from the platform API, with caching and env-var fallback.
|
||||
#
|
||||
# NOTE: post-suspension (2026-05-06), github.com/Molecule-AI is gone;
|
||||
# the helper's platform endpoint also 500s (internal#187). The helper
|
||||
# block is kept for legacy boxes that still have a working token chain;
|
||||
# post-suspension provisioner injects GITEA_TOKEN directly so this
|
||||
# path's failure is non-fatal. Full removal tracked under #171.
|
||||
if [ -x /app/scripts/molecule-git-token-helper.sh ]; then
|
||||
# Set credential helper for github.com only (not all hosts).
|
||||
# The '!' prefix tells git to run the command as a shell command.
|
||||
@ -55,11 +73,13 @@ if [ "$(id -u)" = "0" ]; then
|
||||
"!/app/scripts/molecule-git-token-helper.sh"
|
||||
# Disable other credential helpers for github.com to avoid conflicts.
|
||||
git config --global "credential.https://github.com.useHttpPath" true
|
||||
# Move gitconfig to agent's home so it takes effect after gosu.
|
||||
if [ -f /root/.gitconfig ]; then
|
||||
cp /root/.gitconfig /home/agent/.gitconfig
|
||||
chown agent:agent /home/agent/.gitconfig
|
||||
fi
|
||||
fi
|
||||
# Move gitconfig to agent's home so it takes effect after gosu —
|
||||
# done unconditionally so the per-persona identity survives the drop
|
||||
# even when the github.com helper block is skipped.
|
||||
if [ -f /root/.gitconfig ]; then
|
||||
cp /root/.gitconfig /home/agent/.gitconfig
|
||||
chown agent:agent /home/agent/.gitconfig
|
||||
fi
|
||||
# Create the token cache directory for the agent user.
|
||||
mkdir -p /home/agent/.molecule-token-cache
|
||||
|
||||
Loading…
Reference in New Issue
Block a user