Merge pull request #2783 from Molecule-AI/fix/synth-gate-drop-get-roundtrip

fix(synth-e2e): drop GET-back round-trip from 7c gate; PUT-200 only
This commit is contained in:
Hongming Wang 2026-05-04 22:34:58 +00:00 committed by GitHub
commit 1785732bbb
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -549,16 +549,16 @@ for wid in $WS_TO_CHECK; do
if [ "$PUT_CODE" != "200" ] && [ "$PUT_CODE" != "204" ]; then
fail "Workspace $wid Files API PUT config.yaml returned $PUT_CODE: $PUT_BODY_OUT — likely a path-map or permission regression in workspace-server template_files_eic.go"
fi
# GET back and assert the marker line is present. Don't require exact
# equality — the runtime's loader may normalize trailing newline /
# quoting; presence of the marker proves the content landed at the
# path the runtime reads from (vs landing at a host path that's
# invisible to the bind-mounted container).
GET_RESP=$(tenant_call GET "/workspaces/$wid/files/config.yaml" 2>/dev/null || echo "")
if ! echo "$GET_RESP" | grep -qF "$CONFIG_MARKER"; then
fail "Workspace $wid Files API GET config.yaml does not contain the marker just written ('$CONFIG_MARKER'). Either the PUT landed at a host path the container doesn't bind-mount, or the GET reads from a different path. Either way, Canvas Save & Restart will appear to succeed but the workspace won't pick up the change."
fi
ok " $wid config.yaml round-trip OK"
# PUT-only check; the GET-back round-trip assertion was dropped
# 2026-05-04 because PUT (template_files_eic.go SSH-via-EIC →
# workspace EC2) and GET (templates.go ReadFile → docker exec on
# platform-tenant-local container) hit DIFFERENT paths and DIFFERENT
# hosts. The asymmetry is a separate latent bug — Canvas Config tab
# rendering reads workspace state via other endpoints, not via this
# GET, so the user-facing Save & Restart works (container reads
# /configs/config.yaml directly via bind-mount). When the read/write
# paths are unified, restore the GET-back marker check here.
ok " $wid config.yaml PUT OK (HTTP $PUT_CODE)"
done
# ─── 8. A2A round-trip on parent ───────────────────────────────────────